Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Subnautica: cleanup pass #2293

Merged
merged 2 commits into from
Oct 15, 2023
Merged

Subnautica: cleanup pass #2293

merged 2 commits into from
Oct 15, 2023

Conversation

Berserker66
Copy link
Member

What is this fixing or adding?

Switches Subnautica over to lowercase module names and use of World.options

How was this tested?

unittests + Generate.py

If this makes graphical changes, please attach screenshots.

Copy link
Member

@LegendaryLinux LegendaryLinux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes don't look crazy, and I successfully generated a game locally.

@Berserker66 Berserker66 merged commit fffbe68 into main Oct 15, 2023
21 checks passed
@Berserker66 Berserker66 deleted the subnautica_cleanup branch October 15, 2023 02:51
@ThePhar ThePhar added the is: refactor/cleanup Improvements to code/output readability or organizization. label Oct 17, 2023
FlySniper pushed a commit to FlySniper/Archipelago that referenced this pull request Nov 14, 2023
Jouramie pushed a commit to Jouramie/Archipelago that referenced this pull request Feb 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
is: refactor/cleanup Improvements to code/output readability or organizization.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants