Docs, Various Games: Add Unique Local Commands to Game Page #2285
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FlySniper
approved these changes
Oct 9, 2023
|
Markdown changes in general look okay. Will wait a while for affected world maintainers to respond. |
|
Sorry to add more to this list, but StarCraft 2 has several unique commands missing from this list. Their implementation can be found at |
Co-authored-by: Bicoloursnake <[email protected]>
Thank you for bringing this up. I recognized that I would be missing some clients since not all of them use the CommonClient. I have added these commands in 5396b56 |
|
At this point, I think everyone who is going to give an approval will. I'll leave my approval here, and if nobody has any objections before I stumble through this PR again in a week or so, I'll merge. |
LegendaryLinux
approved these changes
Oct 27, 2023
nicholassaylor
added a commit
to nicholassaylor/Archipelago
that referenced
this pull request
Nov 7, 2023
…rchipelagoMW#2285)" This reverts commit 560c57f.
ThePhar
pushed a commit
that referenced
this pull request
Nov 7, 2023
Co-authored-by: jonloveslegos <[email protected]> Co-authored-by: kindasneaki <[email protected]> Co-authored-by: ScootyPuffJr1 <[email protected]>
FlySniper
pushed a commit
to FlySniper/Archipelago
that referenced
this pull request
Nov 14, 2023
…agoMW#2285) * Add Unique Locals Commands to ChecksFinder * Add Unique Locals Commands to MMBN3 Game Page * Add Unique Locals Commands to Ocarina of Time Game Page * Add Unique Locals Commands to Undertale Game Page * Add Unique Locals Commands to Wargroove Game Page * Add Unique Locals Commands to The Legend of Zelda Game Page * Add Unique Locals Commands to Zillion Game Page * Amend Unique Locals Commands on Final Fantasy 1 Game Page * Add Unique Locals Commands to Pokemon R/B Game Page * Grammar fix for FF1 * Corrected sections names to match * Added commands to Starcraft 2 Wings of Liberty game page Co-authored-by: Bicoloursnake <[email protected]> --------- Co-authored-by: Bicoloursnake <[email protected]>
FlySniper
pushed a commit
to FlySniper/Archipelago
that referenced
this pull request
Nov 14, 2023
…ipelagoMW#2435) Co-authored-by: jonloveslegos <[email protected]> Co-authored-by: kindasneaki <[email protected]> Co-authored-by: ScootyPuffJr1 <[email protected]>
Jouramie
pushed a commit
to Jouramie/Archipelago
that referenced
this pull request
Feb 28, 2024
…agoMW#2285) * Add Unique Locals Commands to ChecksFinder * Add Unique Locals Commands to MMBN3 Game Page * Add Unique Locals Commands to Ocarina of Time Game Page * Add Unique Locals Commands to Undertale Game Page * Add Unique Locals Commands to Wargroove Game Page * Add Unique Locals Commands to The Legend of Zelda Game Page * Add Unique Locals Commands to Zillion Game Page * Amend Unique Locals Commands on Final Fantasy 1 Game Page * Add Unique Locals Commands to Pokemon R/B Game Page * Grammar fix for FF1 * Corrected sections names to match * Added commands to Starcraft 2 Wings of Liberty game page Co-authored-by: Bicoloursnake <[email protected]> --------- Co-authored-by: Bicoloursnake <[email protected]>
Jouramie
pushed a commit
to Jouramie/Archipelago
that referenced
this pull request
Feb 28, 2024
…ipelagoMW#2435) Co-authored-by: jonloveslegos <[email protected]> Co-authored-by: kindasneaki <[email protected]> Co-authored-by: ScootyPuffJr1 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this fixing or adding?
Adds the commands unique to various clients to the appropriate game page.
This PR is in response to the discussion on #2213 concerning where these client commands should be documented.
Commands were pulled from their respective client python files. If any were missed, please let me know so that I can add them.
Additionally, it might be in our interest to require that world maintainers include these commands to their game page. This is not enforced in this PR, but I figured this would be a good place to spark that discussion.
Affected Games and CodeOwners:
How was this tested?
Was not, doc change