Skip to content

MMBN3: Small Bug Fixes #2282

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Nov 24, 2023
Merged

MMBN3: Small Bug Fixes #2282

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
2ce8311
Fixes message box index of Yoka Garbage Can to properly replace item
digiholic Oct 8, 2023
5ff4fc7
Progression items can no longer be placed on the WWW Islands
digiholic Oct 8, 2023
809cf59
Starting items are no longer full local and can be sent by the server
digiholic Oct 8, 2023
95528ea
Update worlds/mmbn3/__init__.py
digiholic Nov 24, 2023
fc38f95
Update worlds/mmbn3/__init__.py
digiholic Nov 24, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion MMBN3Client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@ def _cmd_debug(self):
class MMBN3Context(CommonContext):
command_processor = MMBN3CommandProcessor
game = "MegaMan Battle Network 3"
items_handling = 0b001 # full local
items_handling = 0b101 # full local except starting items

def __init__(self, server_address, password):
super().__init__(server_address, password)
Expand Down
2 changes: 1 addition & 1 deletion worlds/mmbn3/Locations.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -208,7 +208,7 @@ class MMBN3Location(Location):
LocationData(LocationName.ACDC_Class_5B_Bookshelf, 0xb3109e, 0x200024c, 0x40, 0x737634, 235, [5, 6]),
LocationData(LocationName.SciLab_Garbage_Can, 0xb3109f, 0x200024c, 0x8, 0x73AC20, 222, [4, 5]),
LocationData(LocationName.Yoka_Inn_Jars, 0xb310a0, 0x200024c, 0x80, 0x747B1C, 237, [4, 5]),
LocationData(LocationName.Yoka_Zoo_Garbage, 0xb310a1, 0x200024d, 0x8, 0x749444, 226, [4]),
LocationData(LocationName.Yoka_Zoo_Garbage, 0xb310a1, 0x200024d, 0x8, 0x749444, 226, [5]),
LocationData(LocationName.Beach_Department_Store, 0xb310a2, 0x2000161, 0x40, 0x74C27C, 196, [0, 1]),
LocationData(LocationName.Beach_Hospital_Plaque, 0xb310a3, 0x200024c, 0x4, 0x754394, 220, [3, 4]),
LocationData(LocationName.Beach_Hospital_Pink_Door, 0xb310a4, 0x200024d, 0x4, 0x754D00, 220, [4]),
Expand Down
4 changes: 4 additions & 0 deletions worlds/mmbn3/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@
from .Regions import regions, RegionName
from .Names.ItemName import ItemName
from .Names.LocationName import LocationName
from ..generic.Rules import add_item_rule


class MMBN3Settings(settings.Group):
Expand Down Expand Up @@ -91,6 +92,9 @@ def create_regions(self) -> None:
loc = MMBN3Location(self.player, location, self.location_name_to_id.get(location, None), region)
if location in self.excluded_locations:
loc.progress_type = LocationProgressType.EXCLUDED
# Do not place any progressive items on WWW Island
if region_info.name == RegionName.WWW_Island:
add_item_rule(loc, lambda item: not item.advancement)
region.locations.append(loc)
self.multiworld.regions.append(region)
for region_info in regions:
Expand Down