Setup: new setup experience (read: torch almost all of it) #2268

Berserker66 · 2023-10-04T02:44:17Z

What is this fixing or adding?

https://discord.com/channels/731205301247803413/1158944149685411880

In detail:

Less upfront decisions for the user, who might otherwise face a wall of text and confusion.
All registry hooks are always registered, in the past we've seen users not install clients, assign patch files to emulator and mess up their file associations. This should help by having it always installed.
Everything is available. This currently includes a bunch of .exes, which I'd like to move to the Launcher anyway as an ongoing effort.
People need to use the Launcher for apworlds anyway, this gets us further into that path.
A bunch of links in the start menu and desktop are removed in favor of just leaving the launcher.
There is less customizability, and those who did not install everything will have a slightly larger AP on their drive. Since we're not as big as a modern game though, I consider this an ok price to pay.

How was this tested?

By running it on my computer.

If this makes graphical changes, please attach screenshots.

BootsinSoots · 2023-10-04T05:29:00Z

As much as I think being able to pick and choose was nice, this is probably for the best. I can't count the number of times someone got confused because they thought they had to have a rom for everything, or didn't realize they could scroll further.

alwaysintreble · 2023-10-05T06:16:46Z

If you disable Minecraft Forge Server Setup it still includes ArchipelagoMinecraftClient.exe, which will then let you just do the forge server setup then so unsure if we need to leave it in? You're also unable to update sprites without rerunning the installer

2023-10-05.01-15-01.mp4

Berserker66 · 2023-10-05T06:27:32Z

The minecraft thing is fully intentional. I don't know what's going wrong with the adjuster for you, there should be an update sprites button.

alwaysintreble · 2023-10-05T07:16:19Z

fwiw i can repro it from the script too. repro steps:

have no folder at data/sprites/alttpr (either through manually deleting it or just never installing sprites)
run adjuster
open the sprite selection dialog
Window is completely broken whether you open it from single sprite selection or sprite pool selection

el-u · 2023-10-05T13:54:54Z

The broken window usually happens when there is an unhandled exception in the adjuster.

Berserker66 · 2023-10-07T03:59:59Z

Fixed the unrelated bug in #2279

black-sliver · 2023-10-10T19:45:50Z

inno_setup.iss

+Root: HKCR; Subkey: ".aplttp";                                 ValueData: "{#MyAppName}patch";        Flags: uninsdeletevalue; ValueType: string;  ValueName: "";
+Root: HKCR; Subkey: "{#MyAppName}patch";                     ValueData: "Archipelago Binary Patch"; Flags: uninsdeletekey;   ValueType: string;  ValueName: "";
+Root: HKCR; Subkey: "{#MyAppName}patch\DefaultIcon";         ValueData: "{app}\ArchipelagoSNIClient.exe,0";                           ValueType: string;  ValueName: "";
+Root: HKCR; Subkey: "{#MyAppName}patch\shell\open\command";  ValueData: """{app}\ArchipelagoSNIClient.exe"" ""%1""";                  ValueType: string;  ValueName: "";


i do not agree with the tab stops :S

black-sliver

Code looks good, but i can't really test.
Maybe @KonoTyran because of the minecraft checkbox.

One day ™️ we should automate compilation of the .iss, running the installer unattended and rolling a game with it.

KonoTyran · 2023-10-10T21:34:49Z

So it always installs all clients now. Even minecraft if the box is unchecked? I would almost rather it not be there then. As it will do all initialization upon first run. Running the --install param is not required. Just let's one download/setup the server before first game.

LegendaryLinux · 2023-10-10T23:01:18Z

It's probably worth including a storage space requirement on the downloads page now, and to let users know the AP installer is now an all-in-one deal. I'm cool with installing everything since I know the overall space requirement is relatively small.

My one hang-up is related to what Kono said. What does full-initialization mean? Does it install Java? I know the server is Forge, but there's a checkbox for that.

KonoTyran · 2023-10-10T23:23:30Z

the Minecraft client does a few things when it starts up

fetch minecraft_versions.json from my repo to know the proper jdk/forge versions
check JDK (downloads if missing) (with --install it will always delete what it has and re-download)
check forge (download and run installer if missing)
copy apmc file over where it is expected
launch minecraft server.

running it with --install just stops it after step 3. and instead of using the version info from the apmc it uses the first one found in minecraft_versions.json
it will also cache minecraft_versions.json incase it ever does not have internet connection it will still work in a pure local-only environment.

it also never "installs" java it uses a portable .zip version.

LegendaryLinux · 2023-10-10T23:46:42Z

I see. If the user never runs the MC client, that process does not occur, right? If so, I think it is okay to include.

ThePhar · 2023-10-23T18:59:18Z

It's probably worth including a storage space requirement on the downloads page now, and to let users know the AP installer is now an all-in-one deal. I'm cool with installing everything since I know the overall space requirement is relatively small.

My one hang-up is related to what Kono said. What does full-initialization mean? Does it install Java? I know the server is Forge, but there's a checkbox for that.

To be fair, it always installed everything in the background in lib/worlds, so this actually should take up less space because now we don't have the extra .exe files.

Berserker66 · 2023-10-23T19:38:24Z

@KonoTyran so remove the minecraft --install option entirely, leaving only LttP sprite setup?

KonoTyran · 2023-10-23T19:48:06Z

Yea it's not needed. The client will install upon first run of an apmc file.

…goMW#2268)

Berserker66 added 2 commits October 4, 2023 04:37

Setup: new setup experience (read: torch almost all of it)

5a550d5

Setup: tuning of descriptions

7d9dc97

Berserker66 mentioned this pull request Oct 7, 2023

LttP: Adjuster no longer breaks when sprite path doesn't exist. #2279

Merged

black-sliver reviewed Oct 10, 2023

View reviewed changes

some prettification

47ffba8

black-sliver approved these changes Oct 10, 2023

View reviewed changes

el-u mentioned this pull request Oct 16, 2023

Setup: automatically generate Setup Data for SNIClient games #1262

Closed

ThePhar added is: enhancement Issues requesting new features or pull requests implementing new features. affects: core Issues/PRs that touch core and may need additional validation. is: refactor/cleanup Improvements to code/output readability or organizization. labels Oct 17, 2023

remove minecraft ahead of time setup

be70c81

Berserker66 merged commit e394c31 into main Oct 23, 2023

Berserker66 deleted the new_setup branch October 23, 2023 20:07

This was referenced Nov 13, 2023

Installer: Fix invalid component error in inno_setup.iss #2455

Merged

Pokemon RB: Rename launcher entry to 'Pokémon Red and Blue Client', rename client to PokemonRedBlueClient #2457

Closed

FlySniper pushed a commit to FlySniper/Archipelago that referenced this pull request Nov 14, 2023

Setup: new setup experience (read: torch almost all of it) (Archipela…

0b93b78

…goMW#2268)

Jouramie pushed a commit to Jouramie/Archipelago that referenced this pull request Feb 28, 2024

Setup: new setup experience (read: torch almost all of it) (Archipela…

a2d6497

…goMW#2268)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Setup: new setup experience (read: torch almost all of it) #2268

Setup: new setup experience (read: torch almost all of it) #2268

Berserker66 commented Oct 4, 2023

BootsinSoots commented Oct 4, 2023

alwaysintreble commented Oct 5, 2023 •

edited

Loading

Berserker66 commented Oct 5, 2023

alwaysintreble commented Oct 5, 2023 •

edited

Loading

el-u commented Oct 5, 2023

Berserker66 commented Oct 7, 2023

black-sliver Oct 10, 2023

black-sliver left a comment

KonoTyran commented Oct 10, 2023

LegendaryLinux commented Oct 10, 2023

KonoTyran commented Oct 10, 2023 •

edited

Loading

LegendaryLinux commented Oct 10, 2023

ThePhar commented Oct 23, 2023

Berserker66 commented Oct 23, 2023

KonoTyran commented Oct 23, 2023

Setup: new setup experience (read: torch almost all of it) #2268

Setup: new setup experience (read: torch almost all of it) #2268

Conversation

Berserker66 commented Oct 4, 2023

What is this fixing or adding?

How was this tested?

If this makes graphical changes, please attach screenshots.

BootsinSoots commented Oct 4, 2023

alwaysintreble commented Oct 5, 2023 • edited Loading

Berserker66 commented Oct 5, 2023

alwaysintreble commented Oct 5, 2023 • edited Loading

el-u commented Oct 5, 2023

Berserker66 commented Oct 7, 2023

black-sliver Oct 10, 2023

Choose a reason for hiding this comment

black-sliver left a comment

Choose a reason for hiding this comment

KonoTyran commented Oct 10, 2023

LegendaryLinux commented Oct 10, 2023

KonoTyran commented Oct 10, 2023 • edited Loading

LegendaryLinux commented Oct 10, 2023

ThePhar commented Oct 23, 2023

Berserker66 commented Oct 23, 2023

KonoTyran commented Oct 23, 2023

alwaysintreble commented Oct 5, 2023 •

edited

Loading

alwaysintreble commented Oct 5, 2023 •

edited

Loading

KonoTyran commented Oct 10, 2023 •

edited

Loading