WebHost: Show error instead of 500 for unexpected files in multidata zip #2260
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
How about including the name of the unexpected file in the error message? |
Sure. |
black-sliver
requested changes
Oct 7, 2023
Co-authored-by: black-sliver <[email protected]>
ThePhar
added
is: enhancement
FlySniper
pushed a commit
to FlySniper/Archipelago
that referenced
this pull request
Nov 14, 2023
…zip (ArchipelagoMW#2260) * WebHost: Show error instead of 500 for unexpected files in multidata zip * Add filename to error message * Apply suggestions from code review Co-authored-by: black-sliver <[email protected]> --------- Co-authored-by: black-sliver <[email protected]>
Jouramie
pushed a commit
to Jouramie/Archipelago
that referenced
this pull request
Feb 28, 2024
…zip (ArchipelagoMW#2260) * WebHost: Show error instead of 500 for unexpected files in multidata zip * Add filename to error message * Apply suggestions from code review Co-authored-by: black-sliver <[email protected]> --------- Co-authored-by: black-sliver <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this fixing or adding?
https://discord.com/channels/731205301247803413/1158587833435574323
For some reason the Patch.py file from the AP root dir got included in that zip which resulted in a 500 error on upload.
How was this tested?
Uploaded the zip in the above thread on main, saw 500. Applied fix, saw error message instead.