Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WebHost: Add <noscript /> support to Supported Games page #2259

Closed
wants to merge 1 commit into from

Conversation

LegendaryLinux
Copy link
Member

What is this fixing or adding?

Adds first class <noscript /> support to the Supported Games page.

If JS is enabled, the page is displayed as normal.
If JS is disabled, the full content of the page is displayed in a non-interactive format.

How was this tested?

Loaded the page with and without JS enabled in my browser.

If this makes graphical changes, please attach screenshots.

With JS enabled:

image

Without JS enabled:

image

… css issue where the game title did not display a `cursor:pointer` when hovered.
@LegendaryLinux
Copy link
Member Author

I prefer @black-sliver's approach in #2266. Further discussion and development will occur there.

@ThePhar ThePhar changed the title [WebHost] Add <noscript /> support to Supported Games page WebHost: Add <noscript /> support to Supported Games page Oct 17, 2023
@ThePhar ThePhar added is: enhancement Issues requesting new features or pull requests implementing new features. affects: webhost Issues/PRs that touch webhost and may need additional validation. labels Oct 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
affects: webhost Issues/PRs that touch webhost and may need additional validation. is: enhancement Issues requesting new features or pull requests implementing new features.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants