Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pokémon Red and Blue: Adding Spanish Setup Guide #2205

Merged
merged 6 commits into from
Sep 23, 2023
Merged

Pokémon Red and Blue: Adding Spanish Setup Guide #2205

merged 6 commits into from
Sep 23, 2023

Conversation

ShinyNT
Copy link
Contributor

@ShinyNT ShinyNT commented Sep 22, 2023

What is this fixing or adding?

Adding a spanish setup guide for Pokémon Red and Blue, based off the current english guide.

How was this tested?

Translations don't get tested, but I proofchecked it a few times to ensure everything is correct. I also asked advice in #archipelago-dev discord channel to clear up doubts and whatnot, especially the reference format in the init.py file, which I think I got it right (and someone in the channel said it was fine too)

setup_en 100% translated (with a bit of adaptation to spanish linguistics)
add reference to the spanish tutorial
removed temporary "wip translation" header
formatting cleanup
@ShinyNT
Copy link
Contributor Author

ShinyNT commented Sep 22, 2023

ok I didn't mean to do that, I messed up sorry (not sure if it actually affects something though)
image

Copy link
Contributor

@eudaimonistic eudaimonistic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While I'm not a native speaker, I have an intermediate level of Spanish reading and comprehension. This entire translation reads naturally and contains the original information faithfully. Lines 73/74 could use 'por' instead of 'for', but that's the largest nitpick I could find. Looks good!

@ShinyNT
Copy link
Contributor Author

ShinyNT commented Sep 22, 2023

Lines 73/74 could use 'por' instead of 'for', but that's the largest nitpick I could find. Looks good!

just realized it looks like I actually forgot to translate those lines at all lmao, I'm sorry
can I still make a new commit while the pr is open? ok looks like I can. I decided for "para" instead of "por", though, makes more sense that way.

thanks for commenting! I appreciate it a lot

translated "alias for" on lines 73 and 74, which I just forgot to
Copy link
Member

@LegendaryLinux LegendaryLinux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just ran the whole thing through an auto translator to make sure it looked reasonable. Looks good to me.

@LegendaryLinux LegendaryLinux merged commit 2b69820 into ArchipelagoMW:main Sep 23, 2023
@ThePhar ThePhar added the is: documentation Improvements or additions to documentation. label Oct 17, 2023
FlySniper pushed a commit to FlySniper/Archipelago that referenced this pull request Nov 14, 2023
* added setup_es.md

setup_en 100% translated (with a bit of adaptation to spanish linguistics)

* Update __init__.py

add reference to the spanish tutorial

* Update setup_es.md

removed temporary "wip translation" header

* Update setup_es.md

formatting cleanup

* Update setup_es.md

translated "alias for" on lines 73 and 74, which I just forgot to
Jouramie pushed a commit to Jouramie/Archipelago that referenced this pull request Feb 28, 2024
* added setup_es.md

setup_en 100% translated (with a bit of adaptation to spanish linguistics)

* Update __init__.py

add reference to the spanish tutorial

* Update setup_es.md

removed temporary "wip translation" header

* Update setup_es.md

formatting cleanup

* Update setup_es.md

translated "alias for" on lines 73 and 74, which I just forgot to
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
is: documentation Improvements or additions to documentation.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants