Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Plando: verify from_pool type #2200

Merged
merged 1 commit into from
Nov 24, 2023
Merged

Plando: verify from_pool type #2200

merged 1 commit into from
Nov 24, 2023

Conversation

Berserker66
Copy link
Member

What is this fixing or adding?

hopefully https://discord.com/channels/731205301247803413/1153540697031442544

How was this tested?

it wasn't

If this makes graphical changes, please attach screenshots.

@black-sliver
Copy link
Member

Tested

Exception: Plando "from_pool" has to be boolean, not <class 'NoneType'> for player 2.

@ThePhar ThePhar added is: enhancement Issues requesting new features or pull requests implementing new features. affects: core Issues/PRs that touch core and may need additional validation. labels Oct 16, 2023
@ThePhar ThePhar merged commit d892622 into main Nov 24, 2023
21 checks passed
@ThePhar ThePhar deleted the plando_from_pool_bool branch November 24, 2023 16:41
Jouramie pushed a commit to Jouramie/Archipelago that referenced this pull request Feb 28, 2024
@Berserker66 @Jouramie
Plando: verify from_pool type (ArchipelagoMW#2200)
3834076
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@black-sliver black-sliver black-sliver approved these changes

Assignees
No one assigned
Labels
affects: core Issues/PRs that touch core and may need additional validation. is: enhancement Issues requesting new features or pull requests implementing new features.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Berserker66 @black-sliver @ThePhar