Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WebHost: Avoid KeyError in LttP multitracker when non-LttP games are present #2194

Merged

Conversation

remyjette
Copy link
Collaborator

@remyjette remyjette commented Sep 17, 2023

What is this fixing or adding?

If you navigate to the LttP mutlitracker in a multiworld with non-LttP games, the non-LttP game will cause a KeyError because player_location_to_area only contains the LttP games:

File "\WebHostLib\tracker.py", line 1686, in get_LttP_multiworld_tracker
    if location not in player_locations or location not in player_location_to_area[player]:
KeyError: 1

Reported in the replies of https://discord.com/channels/731205301247803413/1152293234677133324

How was this tested?

Loaded WebHost.py after this change, the page loads again.

@Berserker66 Berserker66 merged commit 794959e into ArchipelagoMW:main Sep 20, 2023
@ThePhar ThePhar added is: bug/fix Issues that are reporting bugs or pull requests that are fixing bugs. affects: webhost Issues/PRs that touch webhost and may need additional validation. labels Oct 16, 2023
@remyjette remyjette deleted the fix-alttp-multitracker-keyerror branch November 13, 2023 01:18
FlySniper pushed a commit to FlySniper/Archipelago that referenced this pull request Nov 14, 2023
Jouramie pushed a commit to Jouramie/Archipelago that referenced this pull request Feb 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
affects: webhost Issues/PRs that touch webhost and may need additional validation. is: bug/fix Issues that are reporting bugs or pull requests that are fixing bugs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants