-
Notifications
You must be signed in to change notification settings - Fork 723
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
KH2: Update Game Docs #2188
KH2: Update Game Docs #2188
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
General corrections for grammar and word choice. Ugh, somehow submitted and deleted all my suggestions, hang on, gotta redo them all
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
General grammatical fixes and wording changes
Co-authored-by: Exempt-Medic <[email protected]>
Co-authored-by: Exempt-Medic <[email protected]>
Co-authored-by: Exempt-Medic <[email protected]>
Co-authored-by: Exempt-Medic <[email protected]>
Co-authored-by: Exempt-Medic <[email protected]>
Co-authored-by: Exempt-Medic <[email protected]>
Co-authored-by: Exempt-Medic <[email protected]>
Co-authored-by: Exempt-Medic <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Found two small things. Otherwise, this seems good to me!
Co-authored-by: Exempt-Medic <[email protected]>
Co-authored-by: Exempt-Medic <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just two small nitpicks I have going through the changes. They're not a huge deal in the end, but the rest looks good!
Co-authored-by: Nicholas Saylor <[email protected]>
Co-authored-by: Nicholas Saylor <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Comment from Issue #2295: Under "Best Practices", add "save in file that isn't the first one it shows you upon starting a new game" to prevent accidentally overriding things like async save files
Suggestion by MrPokemon11 after doing a review of game documents
Can you link the original link to the message? from the title of the pr it makes no sense why kh2 is there lmao |
It's actually part of the main github issue but to summarize: someone went through after finding errors with some guides and made a list of discoveries about guides. I've been going through and finding Docs PRs that were somewhat related. In this case, it was just a small suggestion he had regarding the English guide. (I'm not very familiar with github, so I wasn't sure how to go about suggesting the code change) |
just updated the best practices |
Co-authored-by: Exempt-Medic <[email protected]> Co-authored-by: Nicholas Saylor <[email protected]>
Please format your title with what portion of the project this pull request is
targeting and what it's changing.
ex. "MyGame4: implement new game" or "Docs: add new guide for customizing MyGame3"
What is this fixing or adding?
fixing the docs so people can still not read them
How was this tested?
I read them on the local webhost
If this makes graphical changes, please attach screenshots.