Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KH2: Update Game Docs #2188

Merged
merged 18 commits into from
Nov 23, 2023
Merged

Conversation

JaredWeakStrike
Copy link
Collaborator

Please format your title with what portion of the project this pull request is
targeting and what it's changing.

ex. "MyGame4: implement new game" or "Docs: add new guide for customizing MyGame3"

What is this fixing or adding?

fixing the docs so people can still not read them

How was this tested?

I read them on the local webhost

If this makes graphical changes, please attach screenshots.

Copy link
Member

@Exempt-Medic Exempt-Medic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

General corrections for grammar and word choice. Ugh, somehow submitted and deleted all my suggestions, hang on, gotta redo them all

Copy link
Member

@Exempt-Medic Exempt-Medic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

General grammatical fixes and wording changes

worlds/kh2/docs/en_Kingdom Hearts 2.md Outdated Show resolved Hide resolved
worlds/kh2/docs/en_Kingdom Hearts 2.md Outdated Show resolved Hide resolved
worlds/kh2/docs/en_Kingdom Hearts 2.md Outdated Show resolved Hide resolved
worlds/kh2/docs/en_Kingdom Hearts 2.md Outdated Show resolved Hide resolved
worlds/kh2/docs/en_Kingdom Hearts 2.md Show resolved Hide resolved
worlds/kh2/docs/setup_en.md Outdated Show resolved Hide resolved
worlds/kh2/docs/setup_en.md Outdated Show resolved Hide resolved
worlds/kh2/docs/setup_en.md Outdated Show resolved Hide resolved
worlds/kh2/docs/setup_en.md Outdated Show resolved Hide resolved
worlds/kh2/docs/setup_en.md Outdated Show resolved Hide resolved
Copy link
Member

@Exempt-Medic Exempt-Medic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Found two small things. Otherwise, this seems good to me!

worlds/kh2/docs/en_Kingdom Hearts 2.md Outdated Show resolved Hide resolved
worlds/kh2/docs/setup_en.md Outdated Show resolved Hide resolved
JaredWeakStrike and others added 2 commits September 18, 2023 11:41
Co-authored-by: Exempt-Medic <[email protected]>
Co-authored-by: Exempt-Medic <[email protected]>
Copy link
Contributor

@nicholassaylor nicholassaylor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just two small nitpicks I have going through the changes. They're not a huge deal in the end, but the rest looks good!

worlds/kh2/docs/en_Kingdom Hearts 2.md Outdated Show resolved Hide resolved
worlds/kh2/docs/setup_en.md Outdated Show resolved Hide resolved
JaredWeakStrike and others added 2 commits September 26, 2023 12:33
Co-authored-by: Nicholas Saylor <[email protected]>
Co-authored-by: Nicholas Saylor <[email protected]>
Copy link
Contributor

@BootsinSoots BootsinSoots left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment from Issue #2295: Under "Best Practices", add "save in file that isn't the first one it shows you upon starting a new game" to prevent accidentally overriding things like async save files

Suggestion by MrPokemon11 after doing a review of game documents

@JaredWeakStrike
Copy link
Collaborator Author

Comment from Issue #2295: Under "Best Practices", add "save in file that isn't the first one it shows you upon starting a new game" to prevent accidentally overriding things like async save files

Suggestion by MrPokemon11 after doing a review of game documents

Can you link the original link to the message? from the title of the pr it makes no sense why kh2 is there lmao

@BootsinSoots
Copy link
Contributor

It's actually part of the main github issue but to summarize: someone went through after finding errors with some guides and made a list of discoveries about guides. I've been going through and finding Docs PRs that were somewhat related. In this case, it was just a small suggestion he had regarding the English guide. (I'm not very familiar with github, so I wasn't sure how to go about suggesting the code change)

@JaredWeakStrike
Copy link
Collaborator Author

It's actually part of the main github issue but to summarize: someone went through after finding errors with some guides and made a list of discoveries about guides. I've been going through and finding Docs PRs that were somewhat related. In this case, it was just a small suggestion he had regarding the English guide. (I'm not very familiar with github, so I wasn't sure how to go about suggesting the code change)

just updated the best practices

@ScootyPuffJr1 ScootyPuffJr1 added the is: documentation Improvements or additions to documentation. label Oct 16, 2023
@ThePhar ThePhar merged commit a1759ed into ArchipelagoMW:main Nov 23, 2023
7 checks passed
@JaredWeakStrike JaredWeakStrike deleted the kh2-docsupdate branch November 23, 2023 19:46
Jouramie pushed a commit to Jouramie/Archipelago that referenced this pull request Feb 28, 2024
Co-authored-by: Exempt-Medic <[email protected]>
Co-authored-by: Nicholas Saylor <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
is: documentation Improvements or additions to documentation.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants