Pokémon R/B: Fix broken options #2162
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Berserker66
reviewed
Sep 10, 2023
| tm = int(item_name[2:4]) | ||
| move = poke_data.moves[self.local_tms[tm - 1]]["id"] | ||
| data[rom_addresses["Gym_Leader_Moves"] + (2 * i)] = move | ||
| except KeyError: |
There was a problem hiding this comment.
I will once again voice my dislike for except *: pass and leave it at that.
Berserker66
approved these changes
Sep 10, 2023
ThePhar
added
the
is: bug/fix
FlySniper
pushed a commit
to FlySniper/Archipelago
that referenced
this pull request
Nov 14, 2023
Jouramie
pushed a commit
to Jouramie/Archipelago
that referenced
this pull request
Feb 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this fixing or adding?
key_items_onlywhich was attempting to setdexsanityto an invalid value due to a last-minute renaming of the choices, and fixes a crash due to an attempt to check gym leader TM locations to set TM moves.How was this tested?
Generating a
key_items_onlygame with 100% key items required