Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Zillion: webhost config fix #2145

Merged
merged 2 commits into from
Sep 10, 2023

Conversation

beauxq
Copy link
Collaborator

@beauxq beauxq commented Sep 3, 2023

What is this fixing or adding?

Zillion generation on archipelago.gg is failing.

https://discord.com/channels/731205301247803413/1147772247562534996

How was this tested?

I can't reproduce this with my own webhost. Generation works when I run WebHost.py I don't know how the archipelago.gg webhost is configured to make this happen.

This seems like it should fix it based on the error message I see, but without being able to reproduce the webhost configuration, I don't see a way to test whether this fixes the problem.

I made sure it didn't cause any new generation problems with my configuration.

@Berserker66
Copy link
Member

I've deployed the fix to the webhost, on first glance it seems to work.

Copy link
Member

@black-sliver black-sliver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If it's good enough for production, it's good enough for main.

@black-sliver black-sliver merged commit e01eb4e into ArchipelagoMW:main Sep 10, 2023
12 checks passed
@ThePhar ThePhar added the is: bug/fix Issues that are reporting bugs or pull requests that are fixing bugs. label Oct 16, 2023
FlySniper pushed a commit to FlySniper/Archipelago that referenced this pull request Nov 14, 2023
Jouramie pushed a commit to Jouramie/Archipelago that referenced this pull request Feb 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
is: bug/fix Issues that are reporting bugs or pull requests that are fixing bugs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants