Core: Allow any valid priority location in yaml even when they are not used in a given game. #2128
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For some games, the use location group name "Everywhere", results in the generator failing no matter what, as only a subset of the location names will actually be present. A good example of that is Zillion. It has 21 location names per room, of which, only at most 2 is ever used.
CaitSith2
changed the title
Berserker66
reviewed
Sep 15, 2023
Co-authored-by: Fabian Dill <[email protected]>
Berserker66
approved these changes
Sep 20, 2023
ThePhar
added
is: enhancement
FlySniper
pushed a commit
to FlySniper/Archipelago
that referenced
this pull request
Nov 14, 2023
…t used in a given game. (ArchipelagoMW#2128) * Allow any valid priority location in yaml. For some games, the use location group name "Everywhere", results in the generator failing no matter what, as only a subset of the location names will actually be present. A good example of that is Zillion. It has 21 location names per room, of which, only at most 2 is ever used. Co-authored-by: Fabian Dill <[email protected]>
Jouramie
pushed a commit
to Jouramie/Archipelago
that referenced
this pull request
Feb 28, 2024
…t used in a given game. (ArchipelagoMW#2128) * Allow any valid priority location in yaml. For some games, the use location group name "Everywhere", results in the generator failing no matter what, as only a subset of the location names will actually be present. A good example of that is Zillion. It has 21 location names per room, of which, only at most 2 is ever used. Co-authored-by: Fabian Dill <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please format your title with what portion of the project this pull request is
targeting and what it's changing.
ex. "MyGame4: implement new game" or "Docs: add new guide for customizing MyGame3"
What is this fixing or adding?
Generation errors when someone specifies a location that IS a valid location, but is not actually in use for the current game, such as "Cantoran" in time spinner, when the Cantoran boss option is off, or location group name "Everywhere" in certain games, such as Zillion. (that game has 21 location names defined for each of the 74 rooms in the game, of which, only at most 2 of them are ever used in a given game.)
How was this tested?
Generated games using a yaml that specifies priority_locations Everywhere, for games that absolutely doesn't use ALL of its named locations no matter what.
If this makes graphical changes, please attach screenshots.