Factorio, WebHost: fix website multitracker #2126
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
remyjette
reviewed
Aug 28, 2023
Co-authored-by: Remy Jette <[email protected]>
|
I just tested it with progressive techs on and off, seems to be working correctly now. Thanks! |
remyjette
approved these changes
Aug 28, 2023
|
yes |
so, do you want to merge this as-is or fix it in one swoop? |
|
I would prefer to fix that too, if I can find the time to do so. |
black-sliver
approved these changes
Sep 1, 2023
| @@ -1436,6 +1439,17 @@ def _get_inventory_data(data: typing.Dict[str, typing.Any]) -> typing.Dict[int, | |||
| return inventory | |||
|
|
|||
|
|
|||
| def _get_named_inventory(inventory: typing.Dict[int, int], custom_items: typing.Dict[int, str] = None) \ | |||
| -> typing.Dict[str, int]: | |||
| """slow""" | |||
|
Also you are not passing the custom_items in yet. I'm assuming that's a future plan? |
|
nope, forgotten to do |
I just tested it and things appear to be working correctly. I just tested current IDs, not what happens if IDs change, but its working at least if I generate a game on main with this patch. |
ThePhar
added
is: bug/fix
ThePhar
changed the title
FlySniper
pushed a commit
to FlySniper/Archipelago
that referenced
this pull request
Nov 14, 2023
Co-authored-by: Remy Jette <[email protected]>
Jouramie
pushed a commit
to Jouramie/Archipelago
that referenced
this pull request
Feb 28, 2024
Co-authored-by: Remy Jette <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this fixing or adding?
https://discord.com/channels/731205301247803413/1145166962910040104
How was this tested?
minimally
If this makes graphical changes, please attach screenshots.