-
Notifications
You must be signed in to change notification settings - Fork 722
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Factorio: Fix typos in options tooltip #2121
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Silvris
approved these changes
Sep 10, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
ScipioWright
approved these changes
Sep 10, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very minor edit suggestion for consistency, otherwise it looks good to me, even without the edit.
nicholassaylor
suggested changes
Sep 10, 2023
It doesn't let me apply more than one change to the same line in a batch. Co-authored-by: Scipio Wright <[email protected]>
budak7273
commented
Sep 10, 2023
It doesn't let me apply more than one change to the same line in a batch.
black-sliver
approved these changes
Sep 10, 2023
FlySniper
pushed a commit
to FlySniper/Archipelago
that referenced
this pull request
Nov 14, 2023
…MW#2121) * Fix typo in Factorio options tooltip * Fix typo, add details * Apply code review suggestion It doesn't let me apply more than one change to the same line in a batch. Co-authored-by: Scipio Wright <[email protected]> * Apply code review suggestion from @nicholassaylor It doesn't let me apply more than one change to the same line in a batch. --------- Co-authored-by: Scipio Wright <[email protected]>
Jouramie
pushed a commit
to Jouramie/Archipelago
that referenced
this pull request
Feb 28, 2024
…MW#2121) * Fix typo in Factorio options tooltip * Fix typo, add details * Apply code review suggestion It doesn't let me apply more than one change to the same line in a batch. Co-authored-by: Scipio Wright <[email protected]> * Apply code review suggestion from @nicholassaylor It doesn't let me apply more than one change to the same line in a batch. --------- Co-authored-by: Scipio Wright <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this fixing or adding?
How was this tested?
Locally running WebHost.py after making the changes, used to capture the screenshot below
If this makes graphical changes, please attach screenshots.
Before:
After: