Skip to content

The Messenger: Fix a typo preventing a location from being created #2110

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 25, 2023
Merged

The Messenger: Fix a typo preventing a location from being created #2110

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d20263b
The Messenger: Fix a typo preventing a location from being created
alwaysintreble Aug 17, 2023
442e18e
Add a unit test that locations are created
alwaysintreble Aug 17, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion worlds/messenger/Regions.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,7 @@
"Underworld": ["Under Entrance Mega Shard", "Hot Tub Mega Shard", "Projectile Pit Mega Shard"],
"Forlorn Temple": ["Sunny Day Mega Shard", "Down Under Mega Shard"],
"Sunken Shrine": ["Mega Shard of the Moon", "Beginner's Mega Shard", "Mega Shard of the Stars", "Mega Shard of the Sun"],
"RIviere Turquoise Entrance": ["Waterfall Mega Shard"],
"Riviere Turquoise Entrance": ["Waterfall Mega Shard"],
"Riviere Turquoise": ["Quick Restock Mega Shard 1", "Quick Restock Mega Shard 2"],
"Elemental Skylands": ["Earth Mega Shard", "Water Mega Shard"],
}
Expand Down
16 changes: 16 additions & 0 deletions worlds/messenger/test/TestLocations.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,16 @@
from . import MessengerTestBase
from ..SubClasses import MessengerLocation


class LocationsTest(MessengerTestBase):
options = {
"shuffle_shards": "true",
}

@property
def run_default_tests(self) -> bool:
return False

def testLocationsExist(self):
for location in self.multiworld.worlds[1].location_name_to_id:
self.assertIsInstance(self.multiworld.get_location(location, self.player), MessengerLocation)