LADX: Fix hints generation for longer location names #2099
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I was the one who brought this issue up with zig. I merged the changes into my dev branch and it seems to have fixed my issue. |
Berserker66
reviewed
Aug 11, 2023
| expand = False | ||
| if expand: | ||
| st["end"] = 0x4000 | ||
| if info["expand_to_end_of_bank"] == True or st["bank"] in info["expand_to_end_of_bank"]: |
There was a problem hiding this comment.
I believe "== True" is considered bad form.
Berserker66
approved these changes
Aug 11, 2023
ThePhar
added
the
is: bug/fix
FlySniper
pushed a commit
to FlySniper/Archipelago
that referenced
this pull request
Nov 14, 2023
kl3cks7r
pushed a commit
to kl3cks7r/Archipelago
that referenced
this pull request
Dec 15, 2023
Jouramie
pushed a commit
to Jouramie/Archipelago
that referenced
this pull request
Feb 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this fixing or adding?
Fixes text pointer storer running out of space when location name is long by:
...this would be better solved by redoing how owl hint text boxes are done but this is far easier to fix for now.
How was this tested?
Generation with forced long unique hint names. I haven't technically run a ROM using this, but the space is unused, unless something specifically goes looking in bank 9 for zeroes (why?!).
If this makes graphical changes, please attach screenshots.