Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Settings: change/fix tests behavior #2053

Merged
merged 2 commits into from
Jul 29, 2023
Merged

Settings: change/fix tests behavior #2053

merged 2 commits into from
Jul 29, 2023

Conversation

black-sliver
Copy link
Member

What is this fixing or adding?

  • avoid saving and gui stuff when running tests
  • change TestHostYAML to use a fresh yaml rather than the local/user copy
    • host.yaml is .gitignored, so it makes no sense to validate it
    • the test changed from "validate consistency" (between host.yaml and defaults) to "validate output" (of settings)

How was this tested?

By running the tests

@black-sliver
Settings: disable saving and gui during tests
04064da
@black-sliver
Tests: create a fresh host.yaml for TestHostYAML
fedd33c 
Now that host.yaml is .gitignored, testing the local host.yaml makes no sense anymore
@ThePhar ThePhar added the is: bug/fix Issues that are reporting bugs or pull requests that are fixing bugs. label Jul 29, 2023
@black-sliver black-sliver merged commit 7b8f891 into ArchipelagoMW:main Jul 29, 2023
@black-sliver black-sliver deleted the settings-test branch July 29, 2023 16:50
FlySniper pushed a commit to FlySniper/Archipelago that referenced this pull request Nov 14, 2023
@black-sliver @FlySniper
Settings: change/fix tests behavior (ArchipelagoMW#2053)
bf4d97d 
* Settings: disable saving and gui during tests

* Tests: create a fresh host.yaml for TestHostYAML

Now that host.yaml is .gitignored, testing the local host.yaml makes no sense anymore
kl3cks7r pushed a commit to kl3cks7r/Archipelago that referenced this pull request Dec 15, 2023
@black-sliver
Settings: change/fix tests behavior (ArchipelagoMW#2053)
9de72c9 
* Settings: disable saving and gui during tests

* Tests: create a fresh host.yaml for TestHostYAML

Now that host.yaml is .gitignored, testing the local host.yaml makes no sense anymore
Jouramie pushed a commit to Jouramie/Archipelago that referenced this pull request Feb 28, 2024
@black-sliver @Jouramie
Settings: change/fix tests behavior (ArchipelagoMW#2053)
40fd315 
* Settings: disable saving and gui during tests

* Tests: create a fresh host.yaml for TestHostYAML

Now that host.yaml is .gitignored, testing the local host.yaml makes no sense anymore
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Berserker66 Berserker66 Berserker66 approved these changes

Assignees
No one assigned
Labels
is: bug/fix Issues that are reporting bugs or pull requests that are fixing bugs.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@black-sliver @Berserker66 @ThePhar