Core: Set locality rules after set_rules stage.

[ThePhar]

What is this fixing or adding?

If games reassign Location.item_rules in set_rules or generate_basic, then local and non_local item rules will be "overwritten".

For example, Clique sets an item_rule in set_rules (made sense to me), but another player set an item as "local_only". In the seed generated, it may still ended up on the Clique location.

Since there's doesn't appear to be consensus that item_rules should not be set after create_items, this should prevent weird behavior if that were to occur up until item plando and fill stages, where I argue this chance should be less likely.

Since

How was this tested?

Ran unit tests and seed with known placement error, and misplacement disappeared.

If this makes graphical changes, please attach screenshots.

Spoiler:

Before fix w/ same seed:

After fix w/ same seed:

[Berserker66]

rules, this includes item_rules, should be set by the time set_rules is done.

[black-sliver]

If I understand berserker correctly, I agree that the block you moved should instead be right after AutoWorld.call_all(world, "set_rules") so that all rules are set before entering the next stage.

Looking at the blame it seems like this was originally specifically added for HK and then simply stayed there with no specific reason, so moving it is probably fine?

[ThePhar]

So we're all in agreement basically?

I moved it after generate_basic for those who did everything in generate_basic for whatever reason. That is the absolute latest, I'd expect rules to be updated.

[el-u]

Basic is specified as being for things that don't affect logic, so I agree with Berserker and black-sliver.
And I guess having the locality rules in the same place as the exclusion rules (i.e. after set_rules but before generate_basic would seem natural.

[ThePhar]

Whatever, most important thing is it's after set_rules, so changed PR accordingly.