-
Notifications
You must be signed in to change notification settings - Fork 723
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Stardew valley: Supported Mods documentation and changes required for legal reasons #2038
Merged
Berserker66
merged 4 commits into
ArchipelagoMW:main
from
agilbert1412:StardewValley/SupportedModsInformation
Jul 29, 2023
Merged
Stardew valley: Supported Mods documentation and changes required for legal reasons #2038
Berserker66
merged 4 commits into
ArchipelagoMW:main
from
agilbert1412:StardewValley/SupportedModsInformation
Jul 29, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d mods from code and documentation
ThePhar
added
is: documentation
Improvements or additions to documentation.
is: maintenance
Regular updates to requirements and utilities that do not fix bugs or change/add features.
labels
Jul 27, 2023
ScipioWright
approved these changes
Jul 27, 2023
Co-authored-by: Scipio Wright <[email protected]>
Berserker66
approved these changes
Jul 29, 2023
FlySniper
pushed a commit
to FlySniper/Archipelago
that referenced
this pull request
Nov 14, 2023
… legal reasons (ArchipelagoMW#2038) ## What is this fixing or adding? It was pointed out that distributing an archive with copies of all the supported mods could lead to legal problems down the line. So we are moving away from this approach. This also means that, in the event that a mod gets updated and the previous version is no longer available, we need the ability to update the mod's supported version at any point in time, and cannot rely on AP's release schedule for such updates that will, in most cases, be only changing the string for the required version. Changes: - Scrub all references to the support mods zip file from documentation - Create dedicated "Supported Mods" documentation page, external to AP so we can keep it updated with mod versions regardless of their release schedule - Remove mod version validation from the AP backend, and manage that in the mod itself, for the same reason.
kl3cks7r
pushed a commit
to kl3cks7r/Archipelago
that referenced
this pull request
Dec 15, 2023
… legal reasons (ArchipelagoMW#2038) ## What is this fixing or adding? It was pointed out that distributing an archive with copies of all the supported mods could lead to legal problems down the line. So we are moving away from this approach. This also means that, in the event that a mod gets updated and the previous version is no longer available, we need the ability to update the mod's supported version at any point in time, and cannot rely on AP's release schedule for such updates that will, in most cases, be only changing the string for the required version. Changes: - Scrub all references to the support mods zip file from documentation - Create dedicated "Supported Mods" documentation page, external to AP so we can keep it updated with mod versions regardless of their release schedule - Remove mod version validation from the AP backend, and manage that in the mod itself, for the same reason.
Jouramie
pushed a commit
to Jouramie/Archipelago
that referenced
this pull request
Feb 28, 2024
… legal reasons (ArchipelagoMW#2038) ## What is this fixing or adding? It was pointed out that distributing an archive with copies of all the supported mods could lead to legal problems down the line. So we are moving away from this approach. This also means that, in the event that a mod gets updated and the previous version is no longer available, we need the ability to update the mod's supported version at any point in time, and cannot rely on AP's release schedule for such updates that will, in most cases, be only changing the string for the required version. Changes: - Scrub all references to the support mods zip file from documentation - Create dedicated "Supported Mods" documentation page, external to AP so we can keep it updated with mod versions regardless of their release schedule - Remove mod version validation from the AP backend, and manage that in the mod itself, for the same reason.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
is: documentation
Improvements or additions to documentation.
is: maintenance
Regular updates to requirements and utilities that do not fix bugs or change/add features.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this fixing or adding?
It was pointed out that distributing an archive with copies of all the supported mods could lead to legal problems down the line. So we are moving away from this approach.
This also means that, in the event that a mod gets updated and the previous version is no longer available, we need the ability to update the mod's supported version at any point in time, and cannot rely on AP's release schedule for such updates that will, in most cases, be only changing the string for the required version.
Changes:
How was this tested?
Generated, connected, and played a bit on worlds with mods on this new version