Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MultiServer: fix unclosed parenthesis in connection message #2035

Merged
merged 1 commit into from
Jul 28, 2023

Conversation

Silvris
Copy link
Collaborator

@Silvris Silvris commented Jul 26, 2023

What is this fixing or adding?

Removes an unclosed parenthesis within the MultiServer connection message.

How was this tested?

Hosted using MultiServer.py and then joined with a TextClient, confirmed that the resulting message did not contain the additional parenthesis.

If this makes graphical changes, please attach screenshots.

image

@ThePhar ThePhar added is: bug/fix Issues that are reporting bugs or pull requests that are fixing bugs. affects: core Issues/PRs that touch core and may need additional validation. labels Jul 26, 2023
@ThePhar
Copy link
Member

ThePhar commented Jul 26, 2023

I would think it removes an unopened close paren (since the closing paren is there, but theres no open paren).

@Berserker66 Berserker66 merged commit a99a407 into ArchipelagoMW:main Jul 28, 2023
FlySniper pushed a commit to FlySniper/Archipelago that referenced this pull request Nov 14, 2023
kl3cks7r pushed a commit to kl3cks7r/Archipelago that referenced this pull request Dec 15, 2023
Jouramie pushed a commit to Jouramie/Archipelago that referenced this pull request Feb 28, 2024
@Silvris Silvris deleted the connection_typo branch April 16, 2024 05:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
affects: core Issues/PRs that touch core and may need additional validation. is: bug/fix Issues that are reporting bugs or pull requests that are fixing bugs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants