Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CommonClient: fix 0.4.2 EnergyLink datastore key #2034

Merged
merged 1 commit into from
Jul 29, 2023

Conversation

Berserker66
Copy link
Member

What is this fixing or adding?

Should fix issues reported with energy link not working.

How was this tested?

Wasn't yet.

If this makes graphical changes, please attach screenshots.

@ThePhar ThePhar added is: bug/fix Issues that are reporting bugs or pull requests that are fixing bugs. affects: core Issues/PRs that touch core and may need additional validation. labels Jul 25, 2023
Copy link
Contributor

@Alchav Alchav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and it is working

@Berserker66
Copy link
Member Author

Also got around to testing it and looks to work now. Did not actually test multiple teams, but it's reasonably likely that it won't break. If it does break I'll just have to fix it when teams is available.

Copy link
Member

@black-sliver black-sliver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't get to test it, but i believe it's fine if it works for you two.

@Berserker66 Berserker66 merged commit b684ba4 into main Jul 29, 2023
@Berserker66 Berserker66 deleted the commonclient_energylink_key branch July 29, 2023 00:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
affects: core Issues/PRs that touch core and may need additional validation. is: bug/fix Issues that are reporting bugs or pull requests that are fixing bugs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants