Stardew valley: backpack fix #2028
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added a test for backpack locations being absent on vanilla
ThePhar
added
the
is: bug/fix
ThePhar
added
the
affects: release/blocker
|
adding release/blocker as this fixes a sample issue too apparently on RC1: https://discord.com/channels/731205301247803413/731214280439103580/1133164985506340874 |
black-sliver
approved these changes
Jul 24, 2023
FlySniper
pushed a commit
to FlySniper/Archipelago
that referenced
this pull request
Nov 14, 2023
* - Reorganised tests for better backpack coverage - Added a test for backpack locations being absent on vanilla * - Fix backpack locations on vanilla * - Fixed a typo in documentation * - Added missing parenthesis after enum.auto so that Python 3.11 still works * - Added Blank lines at the end of the backpack test files * - cleaned whitespace
kl3cks7r
pushed a commit
to kl3cks7r/Archipelago
that referenced
this pull request
Dec 15, 2023
* - Reorganised tests for better backpack coverage - Added a test for backpack locations being absent on vanilla * - Fix backpack locations on vanilla * - Fixed a typo in documentation * - Added missing parenthesis after enum.auto so that Python 3.11 still works * - Added Blank lines at the end of the backpack test files * - cleaned whitespace
Jouramie
pushed a commit
to Jouramie/Archipelago
that referenced
this pull request
Feb 28, 2024
* - Reorganised tests for better backpack coverage - Added a test for backpack locations being absent on vanilla * - Fix backpack locations on vanilla * - Fixed a typo in documentation * - Added missing parenthesis after enum.auto so that Python 3.11 still works * - Added Blank lines at the end of the backpack test files * - cleaned whitespace
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this fixing or adding?
Fixed a bug where playing on backpack_progression: vanilla would still generate the backpack locations in the pool
Bug was reported by @t3hf1gm3nt here: https://discord.com/channels/731205301247803413/1132878736765767781
Also fixed a bug with the item group enum. On some versions of Python 3.11 only, it was behaving strangely and duplicating the enum, leading to failed generations in most cases
How was this tested?
1 - Reorganised the backpack unit tests for better structure and coverage, and created explicit tests to check the locations on vanilla
2 - Watch the new tests fail to prove that the bug exists
3 - Fix the bug
4 - Watch the tests now succeed
5 - Profit!