DS3: Accessibility error fix #1983
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM, @Marechal-L or @Br00ty please approve |
ThePhar
added
the
is: bug/fix
Br00ty
approved these changes
Jul 21, 2023
ThePhar
approved these changes
Jul 21, 2023
FlySniper
pushed a commit
to FlySniper/Archipelago
that referenced
this pull request
Nov 14, 2023
kl3cks7r
pushed a commit
to kl3cks7r/Archipelago
that referenced
this pull request
Dec 15, 2023
Jouramie
pushed a commit
to Jouramie/Archipelago
that referenced
this pull request
Feb 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this fixing or adding?
Progression items being placed in Archdragon Peak causes
apparently due to the access rule using
can_reach("Go To Untended Graves", "Entrance", self.player)). I also tried usingcan_reach("Consumed King's Garden", "Region", self.player))which caused the same problem. So this adds an event item in CKG for the Path of the Dragon gesture you get just before Untended Graves. Not the most elegant, but using a gesture to reach an area is unique to Path of the Dragon; everything else is an item.Also changes the
late_dlcoption to lock of all the DLC behind Small Doll instead of allowing the first half of the painted world to stay in logic. An oversight from when the painted world was split into two regions.How was this tested?
Generating with the same seed as failed on
mainand seeing the generation succeed in placing progression items in Archdragon Peak.