WebHost: Add a summary row to the Multiworld Tracker #1965
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implements suggestions from the generation-suggestions channel: - https://discord.com/channels/731205301247803413/1124186131911688262 - https://discord.com/channels/731205301247803413/1109513647274856518
ThePhar
added
is: enhancement
|
Requested a review from Farrak for front end changes, but back end changes look fine. I give my approval for those. |
|
I just noticed in a game I'm running on my own webhost that the summary row is still there on the multiFactorioTracker, and is mis-aligned due to the additional columns in that tracker. Presumably it's similarly off for the lttp multi tracker, so I need to look into this. |
LegendaryLinux
requested changes
Aug 13, 2023
Thanks!! And I just updated it to not render the summary row for game-specific multi trackers. |
LegendaryLinux
approved these changes
Aug 29, 2023
FlySniper
pushed a commit
to FlySniper/Archipelago
that referenced
this pull request
Nov 14, 2023
) * WebHost: Add a summary row to the Multiworld Tracker Implements suggestions from the generation-suggestions channel: - https://discord.com/channels/731205301247803413/1124186131911688262 - https://discord.com/channels/731205301247803413/1109513647274856518 * Improve secondsToHours function, and remove jQuery from footerCallback function. * Don't show the summary row on game-specific multi trackers --------- Co-authored-by: Chris Wilson <[email protected]>
Jouramie
pushed a commit
to Jouramie/Archipelago
that referenced
this pull request
Feb 28, 2024
) * WebHost: Add a summary row to the Multiworld Tracker Implements suggestions from the generation-suggestions channel: - https://discord.com/channels/731205301247803413/1124186131911688262 - https://discord.com/channels/731205301247803413/1109513647274856518 * Improve secondsToHours function, and remove jQuery from footerCallback function. * Don't show the summary row on game-specific multi trackers --------- Co-authored-by: Chris Wilson <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this fixing or adding?
Implements suggestions from the generation-suggestions channel to add a summary row to the Multiworld tracker, so games that aren't the big async can see total number of checks/worlds completed easily.
How was this tested?
Generated a one player game, made sure the footer matched exactly. Waited a few minutes to ensure it updated with the main row. Generated a two player game, made sure things added up, made sure that the footer row continued to update as items were found.
If this makes graphical changes, please attach screenshots.