Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: mention all item classifications #1961

Merged
merged 2 commits into from
Jul 22, 2023

Conversation

el-u
Copy link
Collaborator

@el-u el-u commented Jul 9, 2023

What is this fixing or adding?

Review of #1958 showed that documentation of item classifications could be improved.

@el-u
Copy link
Collaborator Author

el-u commented Jul 9, 2023

@kindasneaki

Copy link
Collaborator

@kindasneaki kindasneaki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@ThePhar ThePhar added the is: documentation Improvements or additions to documentation. label Jul 9, 2023
Copy link
Collaborator

@agilbert1412 agilbert1412 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the new wording is an improvement

docs/world api.md Outdated Show resolved Hide resolved
@ThePhar ThePhar merged commit 5843f71 into ArchipelagoMW:main Jul 22, 2023
@el-u el-u deleted the cleanup_world_api branch July 22, 2023 14:56
FlySniper pushed a commit to FlySniper/Archipelago that referenced this pull request Nov 14, 2023
* docs: mention all item classifications

* docs: mention all item classifications: reword skip_balancing and progression_skip_balancing
kl3cks7r pushed a commit to kl3cks7r/Archipelago that referenced this pull request Dec 15, 2023
* docs: mention all item classifications

* docs: mention all item classifications: reword skip_balancing and progression_skip_balancing
Jouramie pushed a commit to Jouramie/Archipelago that referenced this pull request Feb 28, 2024
* docs: mention all item classifications

* docs: mention all item classifications: reword skip_balancing and progression_skip_balancing
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
is: documentation Improvements or additions to documentation.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants