Generate: Change yaml is destroyed to yaml is invalid #1954
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ScipioWright
changed the title
ScipioWright
changed the title
ThePhar
added
affects: core
agilbert1412
approved these changes
Jul 15, 2023
ThePhar
approved these changes
Jul 19, 2023
There was a problem hiding this comment.
LGTM, but since @Berserker66 was requested for review I'll hold off on pressing "merge" immediately, if he has other opinions.
|
Alright, no comments so guess I'm gonna make the call then. |
FlySniper
pushed a commit
to FlySniper/Archipelago
that referenced
this pull request
Nov 14, 2023
kl3cks7r
pushed a commit
to kl3cks7r/Archipelago
that referenced
this pull request
Dec 15, 2023
Jouramie
pushed a commit
to Jouramie/Archipelago
that referenced
this pull request
Feb 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this fixing or adding?
There was some discussion about confusion regarding the "yaml is destroyed" message. "invalid" was suggested as an alternative, and I though it was a good alternative, and it was suggested that a pull request be made for it, so here we are.
How was this tested?
Reading
If this makes graphical changes, please attach screenshots.
N/A