Core: Add display name for item_links Option.
#1952
Conversation
ThePhar
added
is: documentation
| from copy import deepcopy | ||
|
|
||
| from schema import And, Optional, Or, Schema | ||
|
|
||
| from schema import Schema, And, Or, Optional | ||
| from Utils import get_fuzzy_results |
There was a problem hiding this comment.
This looks odd.
I think most common is either no blank line or a single blank line between all imports and all from ... import.
Imports are typically sorted alphabetically.
There was a problem hiding this comment.
The way my IDE is setup, all builtin imports are grouped together, then all pip package imports, then all local project imports.
Ultimately, it's just personal preference and if need be, I can easily revert that tweak.
There was a problem hiding this comment.
PEP8 only requires you to sort each individual group. Groups are separated by a blank line. The 3-way split looks verbose to me.
It's generally OK here, but I'm not sure if reformatting all files you touch (assuming that's automatic) is a good idea.
What is this fixing or adding?
Just adds a display name. Mostly so spoiler prints
Item Linksinstead ofitem_links.Also re-sorts the imports in
Option.pysince my IDE does that. :PHow was this tested?
Looked at spoiler log after generating game.
If this makes graphical changes, please attach screenshots.
wow