alttp: Add fill_slot_data function #1919
Conversation
Add fill_slot_data function. Used by StripesOO7's pop-tracker pack to auto populate settings as convenience for the user
ThePhar
added
the
is: enhancement
|
Should this be disabled in race mode? |
|
Yes |
|
Is that change somewhat close to what you both were thinking of as "disabling in race mode"? |
|
@Berserker66 does this look alright with you now? |
worlds/alttp/__init__.py
Outdated
| def fill_slot_data(self): | ||
| slot_data = {} | ||
| if not self.multiworld.is_race: | ||
| for option_name in alttp_options: |
There was a problem hiding this comment.
I don't like that this is pulling every option in the options system. I know that isn't currently a lot for LTTP, but there's still some there that I doubt you need, like palette shuffle, and this will only get worse as the options get moved over.
There was a problem hiding this comment.
I don't like that this is pulling every option in the options system. I know that isn't currently a lot for LTTP, but there's still some there that I doubt you need, like palette shuffle, and this will only get worse as the options get moved over.
which version would you prefere then?
having a static list, iterating over it and adding it to slot_data?
OR simply having ~20 static, basically identical, lines for each option i need/want for the tracker?
There was a problem hiding this comment.
having a static list, iterating over it and adding it to slot_data?
This exactly. you make it sound like a bad thing? fwiw #993 makes this significantly easier, but we don't have that yet.
There was a problem hiding this comment.
Oh. no. I have nothing against that solution and never had.
I will change that when i'm back home.
There was a problem hiding this comment.
is that what you intended it look like?
…ing all alttp_options. additional options needed to be done separately cause they are not stored the same way as the rest. "mode", "goal", etc. are simple values as the rest are key:value pairs so `.value` is not supported and I didn't want to introduce an if-statement.
…ing all alttp_options. additional options needed to be done separately cause they are not stored the same way as the rest. "mode", "goal", etc. are simple values as the rest are key:value pairs so `.value` is not supported and I didn't want to introduce an if-statement.
…' into LTTP-add-fill_slot_data-function # Conflicts: # worlds/alttp/__init__.py
|
This should have a comment saying what it is for. As the default assumption for slot data would be that the client needs it, which is not the case at all. |
* __init__.py: Add fill_slot_data function Add fill_slot_data function. Used by StripesOO7's pop-tracker pack to auto populate settings as convenience for the user * LTTP__init__.py added race condition to fill_slot_data * added missing self to multiworl.is_race * changed filling of slot_data to fill from static list instead of pulling all alttp_options. additional options needed to be done separately cause they are not stored the same way as the rest. "mode", "goal", etc. are simple values as the rest are key:value pairs so `.value` is not supported and I didn't want to introduce an if-statement. * changed filling of slot_data to fill from static list instead of pulling all alttp_options. additional options needed to be done separately cause they are not stored the same way as the rest. "mode", "goal", etc. are simple values as the rest are key:value pairs so `.value` is not supported and I didn't want to introduce an if-statement. * added a comment to describe the use for the option added to slot_data --------- Co-authored-by: StripesOO7 <[email protected]>
* __init__.py: Add fill_slot_data function Add fill_slot_data function. Used by StripesOO7's pop-tracker pack to auto populate settings as convenience for the user * LTTP__init__.py added race condition to fill_slot_data * added missing self to multiworl.is_race * changed filling of slot_data to fill from static list instead of pulling all alttp_options. additional options needed to be done separately cause they are not stored the same way as the rest. "mode", "goal", etc. are simple values as the rest are key:value pairs so `.value` is not supported and I didn't want to introduce an if-statement. * changed filling of slot_data to fill from static list instead of pulling all alttp_options. additional options needed to be done separately cause they are not stored the same way as the rest. "mode", "goal", etc. are simple values as the rest are key:value pairs so `.value` is not supported and I didn't want to introduce an if-statement. * added a comment to describe the use for the option added to slot_data --------- Co-authored-by: StripesOO7 <[email protected]>
* __init__.py: Add fill_slot_data function Add fill_slot_data function. Used by StripesOO7's pop-tracker pack to auto populate settings as convenience for the user * LTTP__init__.py added race condition to fill_slot_data * added missing self to multiworl.is_race * changed filling of slot_data to fill from static list instead of pulling all alttp_options. additional options needed to be done separately cause they are not stored the same way as the rest. "mode", "goal", etc. are simple values as the rest are key:value pairs so `.value` is not supported and I didn't want to introduce an if-statement. * changed filling of slot_data to fill from static list instead of pulling all alttp_options. additional options needed to be done separately cause they are not stored the same way as the rest. "mode", "goal", etc. are simple values as the rest are key:value pairs so `.value` is not supported and I didn't want to introduce an if-statement. * added a comment to describe the use for the option added to slot_data --------- Co-authored-by: StripesOO7 <[email protected]>
What is this fixing or adding?
Add fill_slot_data function.
Used by StripesOO7's pop-tracker pack to auto populate settings as convenience for the user
How was this tested?
Generated a bunch of seeds and played most of them with a smaller private group.
If this makes graphical changes, please attach screenshots.
N/A