Docs: Create CODEOWNERS document for tracking world maintainers.
#1901
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ThePhar
changed the title
CODEOWNERS document for tracking world maintainers.CODEOWNERS document for tracking world maintainers.
|
This is going to contain errors because not every world maintainer has write access (obviously by design), but the document is still helpful and if GitHub ever decides to allow folks with read-only access to be referenced, then we are good for that day. |
t3hf1gm3nt
suggested changes
Jun 26, 2023
There was a problem hiding this comment.
So the big thing I have issue with is the ordering. I can see you ordered it by the order they appear in the /worlds/ folder. I feel, however, it should be ordered as it appears on the website's supported games/setup guides pages. I will update my list on the discord accordingly to whichever order we go with. Just would like to have consistency between all the lists.
PoryGone
approved these changes
Jun 28, 2023
Exempt-Medic
requested changes
Jun 28, 2023
agilbert1412
approved these changes
Jun 28, 2023
TRPG0
approved these changes
Jun 29, 2023
el-u
approved these changes
Jun 29, 2023
2023-07-11 - Finalization Date for Vote https://discord.com/channels/731205301247803413/1123286507390767267/1128482720218099812 @ThePhar - Vote to Remove (2023-06-27) @black-sliver - Vote to Remove (2023-06-27) @KonoTyran - Vote to Remove (2023-06-27) @Berserker66 - Vote to Remove (2023-07-09) Passed with majority to remove maintainer status.
el-u
reviewed
Jul 12, 2023
black-sliver
approved these changes
Jul 18, 2023
There was a problem hiding this comment.
Approving changes to world maintainer.md
As for CODEOWNERS, it lgtm, but maybe we want a second (or third) opinion if that is the way we want to implement it? Since most auto-pings are broken, we could also rename the file and get rid of that "... contains errors" and implement an action to ping down the road.
|
I personally don't see it as that much of an issue, plus it still allows auto pings for the few of us that are members. But I'll wait til we start RC phase for any additional opinions before I merge in. |
|
I have spent some time looking into actions workflows which can do auto-pings/auto-review-request based on CODEOWNERS; some seem to exist. But for now I don't personally believe it to be a blocker to merging this, nor do I believe renaming the file or the "errors" it avoids really matters |
@BadMagic100 to primarily handle client-side maintenance/updates. @ThePhar to primarily handle Archipelago-side maintenance/updates. https://discord.com/channels/731205301247803413/1131762415021858907 @ThePhar - Approved @BadMagic100 (2023-07-20) and @ThePhar (2023-07-24) as Maintainers @LegendaryLinux - Approved @BadMagic100 (2023-07-20) as Maintainer @Berserker66 - Approved @BadMagic100 (2023-07-26) and @ThePhar (2023-07-26) as Maintainers @black-sliver - Approved @BadMagic100 (2023-07-26) and @ThePhar (2023-07-26) as Maintainers @KonoTyran - Approved @BadMagic100 (2023-07-27) and @ThePhar (2023-07-27) as Maintainers Passed with a majority to set maintainer status for Hollow Knight.
FlySniper
pushed a commit
to FlySniper/Archipelago
that referenced
this pull request
Nov 14, 2023
…rchipelagoMW#1901) * Meta: Create code owners document for tracking and notifying owners of world changes. * Removing @dewiniaid as maintainer for Hollow Knight. 2023-07-11 - Finalization Date for Vote https://discord.com/channels/731205301247803413/1123286507390767267/1128482720218099812 @ThePhar - Vote to Remove (2023-06-27) @black-sliver - Vote to Remove (2023-06-27) @KonoTyran - Vote to Remove (2023-06-27) @Berserker66 - Vote to Remove (2023-07-09) Passed with majority to remove maintainer status. * Adding @BadMagic100 and @ThePhar as maintainers for Hollow Knight. @BadMagic100 to primarily handle client-side maintenance/updates. @ThePhar to primarily handle Archipelago-side maintenance/updates. https://discord.com/channels/731205301247803413/1131762415021858907 @ThePhar - Approved @BadMagic100 (2023-07-20) and @ThePhar (2023-07-24) as Maintainers @LegendaryLinux - Approved @BadMagic100 (2023-07-20) as Maintainer @Berserker66 - Approved @BadMagic100 (2023-07-26) and @ThePhar (2023-07-26) as Maintainers @black-sliver - Approved @BadMagic100 (2023-07-26) and @ThePhar (2023-07-26) as Maintainers @KonoTyran - Approved @BadMagic100 (2023-07-27) and @ThePhar (2023-07-27) as Maintainers Passed with a majority to set maintainer status for Hollow Knight.
kl3cks7r
pushed a commit
to kl3cks7r/Archipelago
that referenced
this pull request
Dec 15, 2023
…rchipelagoMW#1901) * Meta: Create code owners document for tracking and notifying owners of world changes. * Removing @dewiniaid as maintainer for Hollow Knight. 2023-07-11 - Finalization Date for Vote https://discord.com/channels/731205301247803413/1123286507390767267/1128482720218099812 @ThePhar - Vote to Remove (2023-06-27) @black-sliver - Vote to Remove (2023-06-27) @KonoTyran - Vote to Remove (2023-06-27) @Berserker66 - Vote to Remove (2023-07-09) Passed with majority to remove maintainer status. * Adding @BadMagic100 and @ThePhar as maintainers for Hollow Knight. @BadMagic100 to primarily handle client-side maintenance/updates. @ThePhar to primarily handle Archipelago-side maintenance/updates. https://discord.com/channels/731205301247803413/1131762415021858907 @ThePhar - Approved @BadMagic100 (2023-07-20) and @ThePhar (2023-07-24) as Maintainers @LegendaryLinux - Approved @BadMagic100 (2023-07-20) as Maintainer @Berserker66 - Approved @BadMagic100 (2023-07-26) and @ThePhar (2023-07-26) as Maintainers @black-sliver - Approved @BadMagic100 (2023-07-26) and @ThePhar (2023-07-26) as Maintainers @KonoTyran - Approved @BadMagic100 (2023-07-27) and @ThePhar (2023-07-27) as Maintainers Passed with a majority to set maintainer status for Hollow Knight.
Jouramie
pushed a commit
to Jouramie/Archipelago
that referenced
this pull request
Feb 28, 2024
…rchipelagoMW#1901) * Meta: Create code owners document for tracking and notifying owners of world changes. * Removing @dewiniaid as maintainer for Hollow Knight. 2023-07-11 - Finalization Date for Vote https://discord.com/channels/731205301247803413/1123286507390767267/1128482720218099812 @ThePhar - Vote to Remove (2023-06-27) @black-sliver - Vote to Remove (2023-06-27) @KonoTyran - Vote to Remove (2023-06-27) @Berserker66 - Vote to Remove (2023-07-09) Passed with majority to remove maintainer status. * Adding @BadMagic100 and @ThePhar as maintainers for Hollow Knight. @BadMagic100 to primarily handle client-side maintenance/updates. @ThePhar to primarily handle Archipelago-side maintenance/updates. https://discord.com/channels/731205301247803413/1131762415021858907 @ThePhar - Approved @BadMagic100 (2023-07-20) and @ThePhar (2023-07-24) as Maintainers @LegendaryLinux - Approved @BadMagic100 (2023-07-20) as Maintainer @Berserker66 - Approved @BadMagic100 (2023-07-26) and @ThePhar (2023-07-26) as Maintainers @black-sliver - Approved @BadMagic100 (2023-07-26) and @ThePhar (2023-07-26) as Maintainers @KonoTyran - Approved @BadMagic100 (2023-07-27) and @ThePhar (2023-07-27) as Maintainers Passed with a majority to set maintainer status for Hollow Knight.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this fixing or adding?
As it says on the tin. Unforunately, GitHub doesn't allow automatic PR review requests for users without write access, but this is still useful for keeping track of GitHub usernames of world maintainers. Discord usernames can only go so far, if I need to ping someone in GitHub and I don't know their username.
Also updated
world maintainer.mddocument to reference this doc.How was this tested?
I read it.
If this makes graphical changes, please attach screenshots.
N/A