Launcher: deprecate FUNC Component type #1872
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
worlds/LauncherComponents.py
Outdated
| @@ -31,9 +32,8 @@ def __init__(self, display_name: str, script_name: Optional[str] = None, frozen_ | |||
| self.cli = cli | |||
| self.type = component_type or \ | |||
| None if not display_name else \ | |||
There was a problem hiding this comment.
while you are at it,
- i don't think
bool(display_name)should ever beFalse, so we could remove theNone if ...and change the type hint fortypeto not be optional? if we want hide a button, it'd be better to use a special type or an additional flag rather than havingdisplay_name = ""
worlds/LauncherComponents.py
Outdated
|
|
||
|
|
||
| class Type(Enum): | ||
| TOOL = auto() | ||
| FUNC = auto() # not a real component | ||
| FUNC = auto() # not a real component, do not use anymore |
There was a problem hiding this comment.
might be better the other way around? i.e. MISC = auto(); MISC = FUNC ? anyway, this way we can't give a DeprecationWarning. My original idea would've been renaming FUNC -> MISC, and then adding a new FUNC which gets checked and replaecd in Components.__init__ to generate a DeprecationWarning.
Co-authored-by: black-sliver <[email protected]>
black-sliver
approved these changes
Jun 19, 2023
Berserker66
added a commit
that referenced
this pull request
Jun 20, 2023
* Launcher: add hidden component type --------- Co-authored-by: black-sliver <[email protected]>
Witchybun
pushed a commit
to Witchybun/Archipelago
that referenced
this pull request
Jun 26, 2023
* Launcher: add hidden component type --------- Co-authored-by: black-sliver <[email protected]>
FlySniper
pushed a commit
to FlySniper/Archipelago
that referenced
this pull request
Nov 14, 2023
* Launcher: add hidden component type --------- Co-authored-by: black-sliver <[email protected]>
Jouramie
pushed a commit
to Jouramie/Archipelago
that referenced
this pull request
Feb 28, 2024
* Launcher: add hidden component type --------- Co-authored-by: black-sliver <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this fixing or adding?
removes that any callable is always FUNC, instead of say CLIENT
How was this tested?
running Launcher.py
If this makes graphical changes, please attach screenshots.