Generate: improve error message for missing game #1857
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ThePhar
added
the
is: enhancement
|
As a side note, the fuzzy matching is not very good:
:D |
I mean, half the words are there! |
black-sliver
approved these changes
Jun 19, 2023
Witchybun
pushed a commit
to Witchybun/Archipelago
that referenced
this pull request
Jun 26, 2023
--------- Co-authored-by: black-sliver <[email protected]>
FlySniper
pushed a commit
to FlySniper/Archipelago
that referenced
this pull request
Nov 14, 2023
--------- Co-authored-by: black-sliver <[email protected]>
Jouramie
pushed a commit
to Jouramie/Archipelago
that referenced
this pull request
Feb 28, 2024
--------- Co-authored-by: black-sliver <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this fixing or adding?
When using a world that doesn't exist, such as when missing an apworld, the user would just get a KeyError:
<name of world>How was this tested?
Exception: No world found to handle game fAcToRiO. Did you mean 'Factorio' (100% sure)? Check your spelling or installation of that world.
If this makes graphical changes, please attach screenshots.