-
Notifications
You must be signed in to change notification settings - Fork 722
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WebHost: Change default spoiler-option for games generated from WebHost to 3 instead of 0 #1852
Conversation
Rather than override the param default (which I assume was set for a reason), would it not be better to change the endpoint call on the player settings page to pass in the spoiler setting of 3 instead? |
We default it to 3 everywhere else in AP so I'm not entirely convinced it was intentional. If it does get done via endpoint call that'd need to be in |
i forgot that renaming a branch closes the PR -_- i can look into adding it into the 2 .js files but my JS knowledge is very limited |
…st to 3 instead of 0 (ArchipelagoMW#1852) * Change default spoiler-option in WebHostLib/generate.py to 3 instead of 0 * shifting spoiler-default to the JS calls instead of setting it in generate.py --------- Co-authored-by: StripesOO7 <[email protected]>
…st to 3 instead of 0 (ArchipelagoMW#1852) * Change default spoiler-option in WebHostLib/generate.py to 3 instead of 0 * shifting spoiler-default to the JS calls instead of setting it in generate.py --------- Co-authored-by: StripesOO7 <[email protected]>
…st to 3 instead of 0 (ArchipelagoMW#1852) * Change default spoiler-option in WebHostLib/generate.py to 3 instead of 0 * shifting spoiler-default to the JS calls instead of setting it in generate.py --------- Co-authored-by: StripesOO7 <[email protected]>
What is this fixing or adding?
Changed the default spoiler-log option in the WebHostLib/generate.py from 0 to 3 to restore spoilerlog generation when generating directly from the Playersettings page.
How was this tested?
If this makes graphical changes, please attach screenshots.