Tests: sort custom loaded tests #1851
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agilbert1412
approved these changes
May 31, 2023
test/worlds/__init__.py
Outdated
| suite.addTests(loader.discover(folder, top_level_dir=file_path)) | ||
| for test_collection in loader.discover(folder, top_level_dir=file_path): | ||
| for test_suite in test_collection: | ||
| for test_case in test_suite: |
There was a problem hiding this comment.
Could this use all_tests.extend(test_suite) to avoid one level of nesting?
test/worlds/__init__.py
Outdated
| @@ -8,7 +8,13 @@ def load_tests(loader, standard_tests, pattern): | |||
| suite.addTests(standard_tests) | |||
| folders = [os.path.join(os.path.split(world.__file__)[0], "test") | |||
| for world in AutoWorldRegister.world_types.values()] | |||
| all_tests = [] | |||
| for folder in folders: | |||
| if os.path.exists(folder): | |||
There was a problem hiding this comment.
I would invert this if due to the very high nesting in this section
agilbert1412
approved these changes
May 31, 2023
black-sliver
approved these changes
May 31, 2023
ThePhar
added
is: refactor/cleanup
Berserker66
added a commit
that referenced
this pull request
Jun 20, 2023
kindasneaki
pushed a commit
to kindasneaki/Archipelago
that referenced
this pull request
Jun 28, 2023
FlySniper
pushed a commit
to FlySniper/Archipelago
that referenced
this pull request
Nov 14, 2023
Jouramie
pushed a commit
to Jouramie/Archipelago
that referenced
this pull request
Feb 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this fixing or adding?
Sorts tests by folder, resulting in less categories created from our custom loader. Possibly only visible in PyCharm?
How was this tested?
If this makes graphical changes, please attach screenshots.
turns
into