Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The Witness: Hint distribution changes, added locations, misc fixes #1785

Merged
merged 11 commits into from
Jun 20, 2023

Conversation

NewSoupVi
Copy link
Member

@NewSoupVi NewSoupVi commented May 2, 2023

Changes:

  • Hints should feel a lot less same-y now ("Priority hints" are no longer always hints in disguise)
  • Keep Hedge Mazes 1-3 and Pressure Plates 1-3 are added as locations in all settings
  • Desert Final Room Hexagonal & Desert Final Room Bent 3 are added as locations
  • Entries in exclude_locations that are referring to panels are now sent through slot data. This means they can be pre-skipped on the client side.

Fixes:

  • Logic error in the Stoneworks that led to more restrictive seeds than necessary
  • Logic error for Theater Flowers EP that led to more restrictive seeds than necessary
  • Fixed crash in plando when "item" is a dict with weights
  • Spoiler log locations were in random order per region, now they are consistent

@black-sliver
Copy link
Member

I think this is fine, but we really should not add new features while RC5 is out :S

I know it's convenient like this, but it might be better to separate fixes from features in the future, because fixes are more reasonable to merge during RC phase.

@NewSoupVi
Copy link
Member Author

NewSoupVi commented May 4, 2023

That's fine with me in this case. This PR was not intentionally timed to be during an RC phase. Bugs that actually break things badly I've been PRing individually the moment I fix them.
I'll be more clear in the future when I include fixes as a part of a bigger content PR bc I didn't deem them an "emergency"

I know it'd be preferrable if all fixes, no matter how small they seem to me personally, came in seperate PRs. But this is the compromise I'm currently willing to make :P

@ThePhar ThePhar added is: bug/fix Issues that are reporting bugs or pull requests that are fixing bugs. is: enhancement Issues requesting new features or pull requests implementing new features. labels May 31, 2023
@Berserker66 Berserker66 merged commit 845502a into ArchipelagoMW:main Jun 20, 2023
Witchybun pushed a commit to Witchybun/Archipelago that referenced this pull request Jun 26, 2023
…rchipelagoMW#1785)

Changes:

* Hints should feel a lot less same-y now ("Priority hints" are no longer always hints in disguise)
* Keep Hedge Mazes 1-3 and Pressure Plates 1-3 are added as locations in all settings
* Desert Final Room Hexagonal & Desert Final Room Bent 3 are added as locations
* Entries in exclude_locations that are referring to panels are now sent through slot data. This means they can be pre-skipped on the client side.

Fixes:

* Logic error in the Stoneworks that led to more restrictive seeds than necessary
* Logic error for Theater Flowers EP that led to more restrictive seeds than necessary
* Fixed crash in plando when "item" is a dict with weights
* Spoiler log locations were in random order per region, now they are consistent
FlySniper pushed a commit to FlySniper/Archipelago that referenced this pull request Nov 14, 2023
…rchipelagoMW#1785)

Changes:

* Hints should feel a lot less same-y now ("Priority hints" are no longer always hints in disguise)
* Keep Hedge Mazes 1-3 and Pressure Plates 1-3 are added as locations in all settings
* Desert Final Room Hexagonal & Desert Final Room Bent 3 are added as locations
* Entries in exclude_locations that are referring to panels are now sent through slot data. This means they can be pre-skipped on the client side.

Fixes:

* Logic error in the Stoneworks that led to more restrictive seeds than necessary
* Logic error for Theater Flowers EP that led to more restrictive seeds than necessary
* Fixed crash in plando when "item" is a dict with weights
* Spoiler log locations were in random order per region, now they are consistent
Jouramie pushed a commit to Jouramie/Archipelago that referenced this pull request Feb 28, 2024
…rchipelagoMW#1785)

Changes:

* Hints should feel a lot less same-y now ("Priority hints" are no longer always hints in disguise)
* Keep Hedge Mazes 1-3 and Pressure Plates 1-3 are added as locations in all settings
* Desert Final Room Hexagonal & Desert Final Room Bent 3 are added as locations
* Entries in exclude_locations that are referring to panels are now sent through slot data. This means they can be pre-skipped on the client side.

Fixes:

* Logic error in the Stoneworks that led to more restrictive seeds than necessary
* Logic error for Theater Flowers EP that led to more restrictive seeds than necessary
* Fixed crash in plando when "item" is a dict with weights
* Spoiler log locations were in random order per region, now they are consistent
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
is: bug/fix Issues that are reporting bugs or pull requests that are fixing bugs. is: enhancement Issues requesting new features or pull requests implementing new features.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants