-
Notifications
You must be signed in to change notification settings - Fork 722
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Core: refactor some loading mechanisms #1753
Conversation
…why.would.you.do.this.apworld
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This breaks the following use-case:
python Launcher.py Generate
I think the new code handles all use-cases we now have, with one exception: With the current refactor, I think identify can be changed to only return 2 values - the original code would allow launching everything from the AP folder iirc, but that's not required anymore. |
It is reduced to returning 2 values already, but the change in the branch is not showing up in this PR. |
well, merging main into the branch again seems to have refreshed github |
Do we want to log/print/show a message if the argument was ignored/not found? Once we decided that, I think this can be merged |
Co-authored-by: black-sliver <[email protected]>
Co-authored-by: black-sliver <[email protected]>
Co-authored-by: black-sliver <[email protected]>
Co-authored-by: black-sliver <[email protected]>
Co-authored-by: black-sliver <[email protected]>
Co-authored-by: black-sliver <[email protected]>
What is this fixing or adding?
on its own, not much
How was this tested?
together with a new component that comes seperate
If this makes graphical changes, please attach screenshots.