The Messenger: use the new region helpers #1687
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
why does this make further changes to BaseClasses? |
|
The original version of that was short-sighted and it misses my use case where you don't provide names for any of the entrances. Should I do that as a separate PR? |
|
... you leave me speechless. |
|
If we're making more changes to core, let's do those in a separate PR first. |
ThePhar
added
the
is: refactor/cleanup
# Conflicts: # worlds/messenger/SubClasses.py
ThePhar
approved these changes
Jul 22, 2023
FlySniper
pushed a commit
to FlySniper/Archipelago
that referenced
this pull request
Nov 14, 2023
Co-authored-by: Fabian Dill <[email protected]>
kl3cks7r
pushed a commit
to kl3cks7r/Archipelago
that referenced
this pull request
Dec 15, 2023
Co-authored-by: Fabian Dill <[email protected]>
Jouramie
pushed a commit
to Jouramie/Archipelago
that referenced
this pull request
Feb 28, 2024
Co-authored-by: Fabian Dill <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this fixing or adding?
Having The Messenger use the new region management helpers instead of its own custom implementation
How was this tested?
Just the unit tests, though they're thorough.
If this makes graphical changes, please attach screenshots.