SMZ3: Fixed Ganon sign text on AllDungeonsDefeatMotherBrain goal

[ScorelessPine]

Please format your title with what portion of the project this pull request is
targeting and what it's changing.

ex. "MyGame4: implement new game" or "Docs: add new guide for customizing MyGame3"

What is this fixing or adding?

SMZ3's Ganon Sign previously erroneously told the user how many crystals the "ganon_vulnerable" config option rolled, regardless of if it chose the AllDungeonsDefeatMotherBrain goal.

How was this tested?

A game was generated with the problematic settings and the sign was read to confirm the text change. A second game was generated with normal settings to confirm the text does not change on other goals.

If this makes graphical changes, please attach screenshots.

Last note: I would appreciate if anyone would like to suggest alternate wording for the all dungeons goal sign text. The current text is 4 lines long in game, and i'm not sure what total's smz3 uses for all dungeons goal text.

[Berserker66]

How does the sign behave on upstream SMZ3?

[ScorelessPine]

I never really thought to check, it actually has this issue upstream too

[ScorelessPine]

This change was just merged on main as seen in tewtal/SMZ3Randomizer#209
Below is an image from a game generated on beta.samus.link after the change was added to show the functionality should be the same, after 1e6829f.

[ScorelessPine]

https://samus.link/changelog
This change (and a few more fixes) is now reflected on the main site. Ill update the branch with main as well so it can be ready for review.

[Berserker66]

@lordlou looks good to you?

[lordlou]

Yes! Altough, I would maybe wait for the new version of SMZ3 to come out before merging? I would include the fix with the next update of SMZ3 AP. That way, we keep in sync with upstream versioning.

[eudaimonistic]

This fix is live in upstream SMZ3 as of the 11.3.1 release (which is current release as of writing), so I think this is good to merge?

[ScorelessPine]

This fix is live in upstream SMZ3 as of the 11.3.1 release (which is current release as of writing), so I think this is good to merge?

The fix has been in upstream since April, I was kind of just leaving this PR in limbo since @lordlou said they would include this fix with the next release of SMZ3 AP. I could close this PR if that is still the plan but I was leaving it open as a sort of reminder, I suppose.

[lordlou]

This can be merged: it follows Upstream. I'll follow up shortly with another PR to wrap the update to 11.3.1. And maybe another one for some other reported bug fixes and core changes.