-
Notifications
You must be signed in to change notification settings - Fork 723
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SC2: Rebalance item classes #1512
Conversation
This item is never useful to get out of BK and is never part of logic
@TheCondor07 You are the maintainer for this world, so we'd like you to approve this. Some context for anyone reading this PR: StarCraft II has no natural filler items whatsoever; every item in the game has some situational purpose and is nonreplenishable. TheCondor created three filler items specifically for the randomizer (+15 Starting Minerals/Vespene and +2 Starting Supply), but there's only room for about 5? of them in the vanilla location pool. To compensate for this skewed ratio compared to other AP games, less useful items are classified as filler; this is comparable to how the SM AP randomizer classifies many of its Missiles/Super Missiles/Power Bombs as filler despite those items being valuable in the game and potentially even affecting progression. It makes it possible for a StarCraft player to exclude locations, and in a multiworld context, it ensures that excluded locations across the multiworld won't have a bias towards non-SC2 players (sucking up all of the rupees, missiles, and emblems that would let the players in those worlds finish their games faster). It is less important to classify items as filler now that SC2 settings allow the player to customize their item and location pool; they have a limited ability to remove checks that they don't want to complete from the game entirely, and can remove items that would be replaced with filler items if the location pool is large enough. However, in the specific case of Advanced Medic Facilities, I believe it does deserve the filler designation for these reasons:
I approve of this PR, but Condor should see it. I also think it might be better to make this a general filler/useful reclassification PR, these items 'ought to be classified as Useful for their tendency to always be useful in AP regardless of which other items have been received:
|
Added these items, tested by generating a game. Title and description updated |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I support these changes. Still need Condor's approval.
It's been a month, if Condor disapproves this can be reverted. I don't really know what to do about the SC2WOL situation going forward.
It's been a month, if Condor disapproves this can be reverted. I don't really know what to do about the SC2WOL situation going forward.
It's been a month, if Condor disapproves this can be reverted. I don't really know what to do about the SC2WOL situation going forward.
Sets
Advanced Medic Facilities (Medic)
to filler as:This item is never useful to get out of BK and is never part of logic
Sets these items for useful:
As these items are more useful than others in filler class