Add generic multiworld tracker, move lttp multiworld tracker #1478
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Commented on the issue why this will not be merged in its current incarnation. |
freyacodes
changed the title
freyacodes
force-pushed
the
stripped-tracker
branch
from
9840af8 to
bb96208
Compare
freyacodes
force-pushed
the
stripped-tracker
branch
from
bb96208 to
a50cadd
Compare
freyacodes
force-pushed
the
stripped-tracker
branch
from
a50cadd to
4457381
Compare
|
As mentioned in #1477, I think the LttP specific code should be removed, not embraced. |
|
This now has conflicts in the js file |
Berserker66
approved these changes
Mar 7, 2023
|
I'll tinker with this sometime this week. I think the answer is to adjust the header to display a hamburger menu when the screen layout is taller than it is shorter, and have that button be clickable to reveal the menu. |
|
I'll merge it for now, as I want to test it on the test server and it should be functional. Obviously feel free to PR in style upgrades later. |
kindasneaki
pushed a commit
to kindasneaki/Archipelago
that referenced
this pull request
Jun 28, 2023
…lagoMW#1478) Co-authored-by: Berserker
FlySniper
pushed a commit
to FlySniper/Archipelago
that referenced
this pull request
Nov 14, 2023
…lagoMW#1478) Co-authored-by: Berserker
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(Rewritten because of change in scope)
This relates to the discussion in #1477
What is this fixing or adding?
The navigation menu can support multiple multitrackers. It will only appear if there are games present with a specific multitracker available (or if you navigated to one of the specific ones).
How was this tested?
This has been tested by opening the multiworld trackers with and without ALttP worlds. No gameplay was attempted. This PR is based on the latest revision of
mainas of this writing.If this makes graphical changes, please attach screenshots.
Screenshots