KH2 game implementation #1438
Merged
KH2 game implementation #1438
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hghsdfh
Error with print(trsrId[(locName[i])])
Fixed the order of locations and regions numbers
look at get entrance
Logic for form levels For Loops on forbidding items in locations Connect Forms Region(Still need to connect second visits)
I can now finish the ymls
Next is removing items from the item pool
broke somthing and going to update to most recent ap
placed victory on final xemnas Fixed growth level logic TODO:write forms and level yml
This reverts commit b9f5bf3.
… put nothing on levels)
Added Filler control Reformatted alot of things Fixed level stat increases
cleaned up the rules and yml writing added max logic todo:make keyblade locations and assign items
Outputs the yml files
remove the starting crit items take dummy13 copy it to a unused memory
fixed amount of items mixed mod.yml
TODO: Add Goofy and donald itesm to pool make option for if starting on crit to put in plrp yml to make sure they get the items
Added Donald/Goofy Abilites cleaned up some code Made Schmovement hard coded as a option
Cleaned up init and slot data Added progressionLocations to the slot data (used to tell what is in kh2's local items to locations) fixed form logic fixed keyblades locking their proper slot Cleaned up some lists in items
…kStrike/Archipelago into KH2-Game-Implementation
Berserker66
reviewed
Mar 11, 2023
requirements.txt
Outdated
| bsdiff4>=1.2.2 | ||
| Pymem>=1.10.0 |
There was a problem hiding this comment.
your world specific requirements go into your world folder's requirements.txt
Berserker66
reviewed
Mar 16, 2023
worlds/kh2/Options.py
Outdated
|
|
||
| class SoraEXP(Range): | ||
| """Sora Level Exp Multiplier""" | ||
| display = "Sora Level EXP" |
There was a problem hiding this comment.
Suggested change
| display = "Sora Level EXP" | |
| display_name = "Sora Level EXP" |
Berserker66
reviewed
Mar 16, 2023
worlds/kh2/Options.py
Outdated
Comment on lines
116
to
117
| default = False | ||
| class Cups(Choice): |
There was a problem hiding this comment.
Suggested change
| default = False | |
| class Cups(Choice): | |
| default = False | |
| class Cups(Choice): |
Berserker66
reviewed
Mar 16, 2023
worlds/kh2/__init__.py
Outdated
| self.hitlist = list() | ||
| self.filler_items.extend(item_groups["Filler"]) | ||
|
|
||
| if self.multiworld.FinalXemnas[self.player].value == 1: |
There was a problem hiding this comment.
Suggested change
| if self.multiworld.FinalXemnas[self.player].value == 1: | |
| if self.multiworld.FinalXemnas[self.player] == 1: |
all the options support direct comparison, with either the option key, option name str or option int and will check that those options are even plausible
Berserker66
reviewed
Mar 16, 2023
worlds/kh2/__init__.py
Outdated
| elif self.multiworld.LevelDepth[self.player].value == 2: | ||
| # level 50 sanity | ||
| self.totalLocations -= 50 | ||
| elif self.multiworld.LevelDepth[self.player].value == 4: |
There was a problem hiding this comment.
Suggested change
| elif self.multiworld.LevelDepth[self.player].value == 4: | |
| elif self.multiworld.LevelDepth[self.player] == "level_1": |
example for the compare method. I hope that reads easier?
Fixed everything that berserker reviewed Removed .update to dictionaries and did dictionary[key]=value instead fixed duping with the client using a list of items they should have. removed consumable items from the itempool and added them to the shop. Changed munny pouches to give different amounts and more into the pool changed dummy14 and bounty to look better in game ( doesnt really matter for the ap side of things) Fixed requirements.txt to be what it should be.
|
fixed everything from the review and fixed item duping. |
|
okay it is now actually ready for merge |
Berserker66
approved these changes
Mar 20, 2023
kindasneaki
pushed a commit
to kindasneaki/Archipelago
that referenced
this pull request
Jun 28, 2023
FlySniper
pushed a commit
to FlySniper/Archipelago
that referenced
this pull request
Nov 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please format your title with what portion of the project this pull request is
targeting and what it's changing.
ex. "MyGame4: implement new game" or "Docs: add new guide for customizing MyGame3"
What is this fixing or adding?
Adding base support for Kingdom Hearts 2 in Archipelago
How was this tested?
over 30 seeds with every setting with most games that are supported
If this makes graphical changes, please attach screenshots.