Terraria: Implement New Game #1405
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Alchav
reviewed
Jan 23, 2023
espeon65536
suggested changes
Jan 23, 2023
Berserker66
reviewed
Jun 28, 2023
| operator, #: bool | None, | ||
| conditions, #: list[tuple[bool, int, str | tuple[bool | None, list], str | int | None]], | ||
| ) -> bool: | ||
| if operator is None: |
There was a problem hiding this comment.
This feels like it could be done with assert, to be skipped when shipped, as this should only raise during dev, correct?
There was a problem hiding this comment.
No, operator is allowed to be None when there's only one condition in the group. Like if some conditions are just Wall of Flesh, no & or | is provided, so operator is None. As opposed to Wall of Flesh & Plantera, where operator would be false to represent &
ThePhar
requested changes
Jul 6, 2023
Co-authored-by: Zach Parks <[email protected]>
Co-authored-by: Zach Parks <[email protected]>
Co-authored-by: Zach Parks <[email protected]>
Co-authored-by: Zach Parks <[email protected]>
Co-authored-by: Zach Parks <[email protected]>
Co-authored-by: Zach Parks <[email protected]>
Co-authored-by: Zach Parks <[email protected]>
ThePhar
approved these changes
Jul 19, 2023
FlySniper
pushed a commit
to FlySniper/Archipelago
that referenced
this pull request
Nov 14, 2023
Co-authored-by: Zach Parks <[email protected]> Co-authored-by: Fabian Dill <[email protected]>
kl3cks7r
pushed a commit
to kl3cks7r/Archipelago
that referenced
this pull request
Dec 15, 2023
Co-authored-by: Zach Parks <[email protected]> Co-authored-by: Fabian Dill <[email protected]>
Jouramie
pushed a commit
to Jouramie/Archipelago
that referenced
this pull request
Feb 28, 2024
Co-authored-by: Zach Parks <[email protected]> Co-authored-by: Fabian Dill <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this fixing or adding?
Terraria world randomization
How was this tested?
Manual verification and existing unit tests. Also, the parser checks for many errors in the data file (syntax errors, unrecognized logic functions, unrecognized item names, and duplicate items/locations/goals/flags/etc).
Some info to help the review process (see this)
People who have worked on this: just me (Discord @seldom_se)
Design thread
Current
apworldI think this message and the next several messages following it show the current state of this integration. Most people don't run into any bugs, but some do, though they tend to be on the client-side. I occasionally tweak the logic for balance and fixes, and to account for discovered skips.
Calamity support is nearly done, but I'll save that for another pr. There are quite a few known bugs on the client at the moment.
I'll keep this comment up-to-date with the current state of the integration until it's merged