-
Notifications
You must be signed in to change notification settings - Fork 722
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docs, LTTP: clarify not using qusb and remove redundancies #1373
Conversation
This might also want to be applied to smz3 and possibly other snes guides |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a couple of suggestions! Looks good to me otherwise. :)
Following @black-sliver putting this up to community review, I went and looked through this. The update looks good. Soldier's recommendations also look good with the one caveat I noted above. |
This looks good to me, language-wise. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we're gonna edit this doc, we may also want to update the sections that reference which lua to load.
See:
You're looking in the wrong directory. lttp still uses the SNI connector, that hasn't changed. /SNI/lua/ which the guide references. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did absolutely read it wrong. I shouldn't review after a certain hour. LGTM
…goMW#1373) * clarify not using qusb and remove redundancies * SNES mini note * review suggestions * remove remaining repetitive text --------- Co-authored-by: black-sliver <[email protected]>
…goMW#1373) * clarify not using qusb and remove redundancies * SNES mini note * review suggestions * remove remaining repetitive text --------- Co-authored-by: black-sliver <[email protected]>
What is this fixing or adding?
Hopefully reduce people trying and failing to use QUsb2SNES
How was this tested?
I read it.