Subnautica: Rename location check (id 33029) #1120
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update southwest grassy plateaus wreck to 'Grassy Plateaus Southwest Wreck - Databox' instead of 'Grassy Plateaus West Wreck - Databox'
black-sliver
added
the
is: enhancement
|
Changing a location name will also require an increment of the |
Berserker66
requested changes
Nov 1, 2022
Description: + Update data_version to reflect the change in location name.
|
Thank you both for the feedback! Per your request, I have updated the data_version and have created a separate PR for the poptracker, which can be found here. @Berserker66 I'm not entirely sure if those changes in the poptracker were what you were requesting (I believe the Crater.json file was correct already, barring the minor discrepancies in naming), so if I missed/overlooked something or misunderstood your request, let me know! |
Berserker66
approved these changes
Feb 26, 2023
kindasneaki
pushed a commit
to kindasneaki/Archipelago
that referenced
this pull request
Jun 28, 2023
Update southwest grassy plateaus wreck to 'Grassy Plateaus Southwest Wreck - Databox' instead of 'Grassy Plateaus West Wreck - Databox'
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this fixing or adding?
Updates the name of 'Grassy Plateaus West Wreck - Databox' to 'Grassy Plateaus Southwest Wreck - Databox'. This helps distinguish between the two distinct wrecks within the western grassy plateaus area and brings the name into alignment with the Poptracker Subnautica package.
How was this tested?
I did not perform any testing of this change, since at this time I am unsure how to build the Archipelago project from source and this was a relatively simple change to a JSON file name. If desired, I can learn how to build the Archipelago source and verify this JSON change works as intended.