Deathlink, first pass. #81
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Oh, for documentation: The DeathLinkIcon is public domain clipart, sourced from: I experimented with using the shade's Hunter's Journal icon, but ditched it due to not being particularly visible in dark environments. Replacement art is welcome. |
Ijwu
added
enhancement
Closed
Ijwu
reviewed
Jun 19, 2022
- Move most Deathlink support into a dedicated DeathLinkSupport class - Override shade respawn locations in certain rooms to make them safe. - Other code quality updates
|
Moved all of the Deathlink support into DeathlinkSupport.cs and a dedicated helper class. Ran out of time so haven't tested this commit yet, but it's mostly just variable renaming other than the messaging bits. Will give it proper testing later -- likely in conjunction with other features with @Alchav |
- Can now trigger in dream sequences. - ShouldShadeSwap(): Use map zone instead of scene name to filter out dream sequences - SendDeathLink() now returns immediately if the current death was triggered by DeathLink so callers don't need to. - Ditch a modhook function that did nothing but call SendDeathLink, just use SendDeathLink instead - Actually pick messages if the cause of death was unknown so the death sends. - Remove unused using directives.
Ijwu
reviewed
Jun 21, 2022
Co-authored-by: Hussein Farran <[email protected]>
Ijwu
approved these changes
Jun 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a first stab of Deathlink. It probably needs a bit of code reorg, but I wanted to get it visible.
Depends on serverside supported added in ArchipelagoMW/Archipelago#672
Should properly handle dream sequences and other no-shade areas. Needs testing in some special cases; I saw some weirdness in GG_Atrium deaths respawning me at the dreamnail scene but oddly killing myself with the debug mod did not trigger this behavior.