Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion src/TickerQ.Utilities/TickerHelper.cs
Original file line number Diff line number Diff line change
Expand Up @@ -73,8 +73,14 @@ public static byte[] CreateTickerRequest<T>(T data)

public static T ReadTickerRequest<T>(byte[] gzipBytes)
{
if (gzipBytes == null || gzipBytes.Length == 0)
return default;

var serializedObject = ReadTickerRequestAsString(gzipBytes);


if (string.IsNullOrWhiteSpace(serializedObject))
return default;

return JsonSerializer.Deserialize<T>(serializedObject, RequestJsonSerializerOptions);
}

Expand Down
64 changes: 64 additions & 0 deletions tests/TickerQ.Tests/TickerHelperTests.cs
Original file line number Diff line number Diff line change
Expand Up @@ -151,6 +151,70 @@ public void ReadTickerRequestAsString_WithCompression_ThrowsForNonGzipBytes()

#endregion

#region ReadTickerRequest - Null/Empty Input

[Fact]
public void ReadTickerRequest_NullBytes_ReturnsDefault()
{
TickerHelper.UseGZipCompression = false;

var result = TickerHelper.ReadTickerRequest<TestPayload>(null);

Assert.Null(result);
}

[Fact]
public void ReadTickerRequest_EmptyBytes_ReturnsDefault()
{
TickerHelper.UseGZipCompression = false;

var result = TickerHelper.ReadTickerRequest<TestPayload>(Array.Empty<byte>());

Assert.Null(result);
}

[Fact]
public void ReadTickerRequest_NullBytes_NullableValueType_ReturnsDefault()
{
TickerHelper.UseGZipCompression = false;

var result = TickerHelper.ReadTickerRequest<int?>(null);

Assert.Null(result);
}

[Fact]
public void ReadTickerRequest_EmptyBytes_WithCompression_ReturnsDefault()
{
TickerHelper.UseGZipCompression = true;

var result = TickerHelper.ReadTickerRequest<TestPayload>(Array.Empty<byte>());

Assert.Null(result);
}

[Fact]
public void ReadTickerRequest_WhitespaceBytes_ReturnsDefault()
{
TickerHelper.UseGZipCompression = false;

var result = TickerHelper.ReadTickerRequest<int?>(Encoding.UTF8.GetBytes(" "));

Assert.Null(result);
}

[Fact]
public void ReadTickerRequest_WhitespaceBytes_ReferenceType_ReturnsDefault()
{
TickerHelper.UseGZipCompression = false;

var result = TickerHelper.ReadTickerRequest<TestPayload>(Encoding.UTF8.GetBytes(""));

Assert.Null(result);
}

#endregion

#region Round-Trip Tests

[Fact]
Expand Down
Loading