Skip to content

fix: Host auth. should not depend on Authorization header #481

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
arcenox merged 1 commit into from
Jan 12, 2026
Merged

fix: Host auth. should not depend on Authorization header #481

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion src/TickerQ.Dashboard/Authentication/AuthService.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,12 @@
return AuthResult.Success("anonymous");
}

// Authentication performed by host application
if (_config.Mode == AuthMode.Host)
{
return AuthenticateHostAsync(context);

Check failure on line 38 in src/TickerQ.Dashboard/Authentication/AuthService.cs

View workflow job for this annotation

GitHub Actions / PR Build and Test 

Since this is an async method, the return expression must be of type 'AuthResult' rather than 'Task<AuthResult>'

Check failure on line 38 in src/TickerQ.Dashboard/Authentication/AuthService.cs

View workflow job for this annotation

GitHub Actions / PR Build and Test 

Since this is an async method, the return expression must be of type 'AuthResult' rather than 'Task<AuthResult>'
}

// Get authorization header or query parameter
var authHeader = GetAuthorizationValue(context);
if (string.IsNullOrEmpty(authHeader))
Expand All @@ -45,7 +51,6 @@
AuthMode.Basic => await AuthenticateBasicAsync(authHeader),
AuthMode.ApiKey => await AuthenticateApiKeyAsync(authHeader),
AuthMode.Custom => await AuthenticateCustomAsync(authHeader),
AuthMode.Host => await AuthenticateHostAsync(context),
_ => AuthResult.Failure("Invalid authentication mode")
};
}
Expand All @@ -66,7 +71,7 @@
};
}

private string? GetAuthorizationValue(HttpContext context)

Check warning on line 74 in src/TickerQ.Dashboard/Authentication/AuthService.cs

View workflow job for this annotation

GitHub Actions / PR Build and Test 

The annotation for nullable reference types should only be used in code within a '#nullable' annotations context.
{
// Try Authorization header first
var authHeader = context.Request.Headers.Authorization.FirstOrDefault();
Expand Down
Loading