Implicitly create buckets for CREATE TYPE by gramian · Pull Request #926 · ArcadeData/arcadedb

gramian · 2023-03-09T09:53:47Z

What does this PR do?

These changes add implicit bucket creation for the SQL CREATE TYPE statement.
To this end I updated CREATE DOCUMENT TYPE, CREATE VERTEX TYPE, and CREATE EDGE TYPE with a conditional bucket creation based on ALTER TYPE, see https://github.com/ArcadeData/arcadedb/blob/main/engine/src/main/java/com/arcadedb/query/sql/parser/AlterTypeStatement.java#L121

Motivation

The docs state that not existing buckets are created when creating type.

Related issues

#892

Additional Notes

Given that I added three times the same code, maybe this mechanism should go to [CreateTypeAbstractStatement.java](https://github.com/ArcadeData/arcadedb/blob/main/engine/src/main/java/com/arcadedb/query/sql/parser/CreateTypeAbstractStatement.java)

Checklist

I have run the build using mvn clean package command
My unit tests cover both failure and success scenarios - I have not written tests

During testing I get:

[ERROR] Failures: 
[ERROR]   LSMTreeIndexTest.testUniqueConcurrentWithIndexesCompaction:1125 expected: <2000> but was: <2001>

but I cannot say if this is related.

lvca · 2023-03-09T14:41:11Z

Thanks, @gramian! It's a good idea to have only one method in CreateTypeAbstractStatement. Please let me know if you can do it or I can merge and do a quick refactor.

gramian · 2023-03-09T14:47:53Z

It would be great if you can do the refactor.

Refers to #926 (comment)

…to 4.1.3 [skip ci] Bumps [io.github.ascopes:protobuf-maven-plugin](https://github.com/ascopes/protobuf-maven-plugin) from 4.1.2 to 4.1.3. Release notes *Sourced from [io.github.ascopes:protobuf-maven-plugin's releases](https://github.com/ascopes/protobuf-maven-plugin/releases).* > v4.1.3 > ------ > > * Added warning logging for deprecated parameter use > * Refactored some internals for incremental cache management logic > * Simplified internal model generation > * Bump protobuf-java internally from 4.33.2 to 4.33.5 > * Several improvements to documentation: > + Improved search engine optimisation > + Improved corporate usage advice > + Added advice for developing JVM-based Maven plugins > + Added advice for cross-platform plugin development > * Updated internal dependencies and test dependencies to the latest version > > Manually tagged this time as Maven Central broke the automated builds again by returning 500 errors upon publication. Commits * [`b0cfdc0`](ascopes/protobuf-maven-plugin@b0cfdc0) [maven-release-plugin] prepare release v4.1.3 * [`cbe5017`](ascopes/protobuf-maven-plugin@cbe5017) Fix deprecation message details * [`9e065dd`](ascopes/protobuf-maven-plugin@9e065dd) Merge pull request [#929](https://github.com/ascopes/protobuf-maven-plugin/issues/929) from ascopes/task/v5-deprecation-message * [`8ce7786`](ascopes/protobuf-maven-plugin@8ce7786) Fix CI formatting * [`8df8081`](ascopes/protobuf-maven-plugin@8df8081) Remove manual codecov trigger that is no longer respected * [`d497214`](ascopes/protobuf-maven-plugin@d497214) Warn users utilising deprecated parameters for protoc plugins * [`32a0701`](ascopes/protobuf-maven-plugin@32a0701) Fix typo in pom.xml * [`8c14a11`](ascopes/protobuf-maven-plugin@8c14a11) Merge pull request [#927](https://github.com/ascopes/protobuf-maven-plugin/issues/927) from ascopes/dependabot/maven/main/com.uber.nullaway-... * [`c4ae18b`](ascopes/protobuf-maven-plugin@c4ae18b) Bump com.uber.nullaway:nullaway from 0.13.0 to 0.13.1 * [`ae64397`](ascopes/protobuf-maven-plugin@ae64397) Merge pull request [#926](https://github.com/ascopes/protobuf-maven-plugin/issues/926) from ascopes/dependabot/maven/main/org.apache.maven.p... * Additional commits viewable in [compare view](ascopes/protobuf-maven-plugin@v4.1.2...v4.1.3) [![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility\_score?dependency-name=io.github.ascopes:protobuf-maven-plugin&package-manager=maven&previous-version=4.1.2&new-version=4.1.3)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot show ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

…28.2 in /studio [skip ci] Bumps [browserslist](https://github.com/browserslist/browserslist) from 4.28.1 to 4.28.2. Release notes *Sourced from [browserslist's releases](https://github.com/browserslist/browserslist/releases).* > 4.28.2 > ------ > > * Fix prototype pollution (by [`@chluo1997`](https://github.com/chluo1997)). Changelog *Sourced from [browserslist's changelog](https://github.com/browserslist/browserslist/blob/main/CHANGELOG.md).* > 4.28.2 > ------ > > * Fix prototype pollution (by [`@chluo1997`](https://github.com/chluo1997)). Commits * [`502ea00`](browserslist/browserslist@502ea00) Release 4.28.2 version * [`4621a79`](browserslist/browserslist@4621a79) Re-use single constant * [`0b5a150`](browserslist/browserslist@0b5a150) Update email * [`8e105c8`](browserslist/browserslist@8e105c8) Process all files with oxfmt * [`a6247d5`](browserslist/browserslist@a6247d5) Add oxfmt support * [`32e5cb1`](browserslist/browserslist@32e5cb1) Update dependencies * [`60c60b7`](browserslist/browserslist@60c60b7) Merge pull request [#926](https://github.com/browserslist/browserslist/issues/926) from chluo1997/fix-pp * [`f263978`](browserslist/browserslist@f263978) fix: prevent prototype pollution * [`2b97b75`](browserslist/browserslist@2b97b75) Merge pull request [#924](https://github.com/browserslist/browserslist/issues/924) from SethFalco/custom-stats * [`f366165`](browserslist/browserslist@f366165) docs: add more details on custom stats * Additional commits viewable in [compare view](browserslist/browserslist@4.28.1...4.28.2) [![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility\_score?dependency-name=browserslist&package-manager=npm\_and\_yarn&previous-version=4.28.1&new-version=4.28.2)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot show ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps [uuid](https://github.com/uuidjs/uuid) to 14.0.0 and updates ancestor dependency [testcontainers](https://github.com/testcontainers/testcontainers-node). These dependencies need to be updated together. Updates `uuid` from 10.0.0 to 14.0.0 Release notes *Sourced from [uuid's releases](https://github.com/uuidjs/uuid/releases).* > v14.0.0 > ------- > > [14.0.0](uuidjs/uuid@v13.0.0...v14.0.0) (2026-04-19) > ------------------------------------------------------------------------------- > > ### ⚠ BREAKING CHANGES > > * expect `crypto` to be global everywhere (requires node@20+) ([#935](https://github.com/uuidjs/uuid/issues/935)) > * drop node@18 support ([#934](https://github.com/uuidjs/uuid/issues/934)) > > ### Features > > * drop node@18 support ([#934](https://github.com/uuidjs/uuid/issues/934)) ([dc4ddb8](uuidjs/uuid@dc4ddb8)) > > ### Bug Fixes > > * expect `crypto` to be global everywhere (requires node@20+) ([#935](https://github.com/uuidjs/uuid/issues/935)) ([f2c235f](uuidjs/uuid@f2c235f)) > * Use GITHUB\_TOKEN for release-please and enable npm provenance ([#925](https://github.com/uuidjs/uuid/issues/925)) ([ffa3138](uuidjs/uuid@ffa3138)) > > v13.0.2 > ------- > > [13.0.2](uuidjs/uuid@v13.0.1...v13.0.2) (2026-05-04) > ------------------------------------------------------------------------------- > > ### Bug Fixes > > * rerelease to fix provenance. ([49ccb35](uuidjs/uuid@49ccb35)) > > v13.0.1 > ------- > > [13.0.1](uuidjs/uuid@v13.0.0...v13.0.1) (2026-04-27) > ------------------------------------------------------------------------------- > > ### Bug Fixes > > * backport fix for GHSA-w5hq-g745-h8pq ([9d27ddf](uuidjs/uuid@9d27ddf)) > > v13.0.0 > ------- > > [13.0.0](uuidjs/uuid@v12.0.0...v13.0.0) (2025-09-08) > ------------------------------------------------------------------------------- > > ### ⚠ BREAKING CHANGES > > * make browser exports the default ([#901](https://github.com/uuidjs/uuid/issues/901)) > > ### Bug Fixes > > * make browser exports the default ([#901](https://github.com/uuidjs/uuid/issues/901)) ([bce9d72](uuidjs/uuid@bce9d72)) > > v12.0.1 > ------- > > [12.0.1](uuidjs/uuid@v12.0.0...v12.0.1) (2026-04-29) > ------------------------------------------------------------------------------- ... (truncated) Changelog *Sourced from [uuid's changelog](https://github.com/uuidjs/uuid/blob/main/CHANGELOG.md).* > [14.0.0](uuidjs/uuid@v13.0.0...v14.0.0) (2026-04-19) > ------------------------------------------------------------------------------- > > ### Security > > * Fixes [GHSA-w5hq-g745-h8pq](GHSA-w5hq-g745-h8pq): `v3()`, `v5()`, and `v6()` did not validate that writes would remain within the bounds of a caller-supplied buffer, allowing out-of-bounds writes when an invalid `offset` was provided. A `RangeError` is now thrown if `offset < 0` or `offset + 16 > buf.length`. > > ### ⚠ BREAKING CHANGES > > * `crypto` is now expected to be globally defined (requires node@20+) ([#935](https://github.com/uuidjs/uuid/issues/935)) > * drop node@18 support ([#934](https://github.com/uuidjs/uuid/issues/934)) > * upgrade minimum supported TypeScript version to 5.4.3, in keeping with the project's policy of supporting TypeScript versions released within the last two years > > [13.0.0](uuidjs/uuid@v12.0.0...v13.0.0) (2025-09-08) > ------------------------------------------------------------------------------- > > ### ⚠ BREAKING CHANGES > > * make browser exports the default ([#901](https://github.com/uuidjs/uuid/issues/901)) > > ### Bug Fixes > > * make browser exports the default ([#901](https://github.com/uuidjs/uuid/issues/901)) ([bce9d72](uuidjs/uuid@bce9d72)) > > [12.0.0](uuidjs/uuid@v11.1.0...v12.0.0) (2025-09-05) > ------------------------------------------------------------------------------- > > ### ⚠ BREAKING CHANGES > > * update to typescript@5.2 ([#887](https://github.com/uuidjs/uuid/issues/887)) > * remove CommonJS support ([#886](https://github.com/uuidjs/uuid/issues/886)) > * drop node@16 support ([#883](https://github.com/uuidjs/uuid/issues/883)) > > ### Features > > * add node@24 to ci matrix ([#879](https://github.com/uuidjs/uuid/issues/879)) ([42b6178](uuidjs/uuid@42b6178)) > * drop node@16 support ([#883](https://github.com/uuidjs/uuid/issues/883)) ([0f38cf1](uuidjs/uuid@0f38cf1)) > * remove CommonJS support ([#886](https://github.com/uuidjs/uuid/issues/886)) ([ae786e2](uuidjs/uuid@ae786e2)) > * update to typescript@5.2 ([#887](https://github.com/uuidjs/uuid/issues/887)) ([c7ee405](uuidjs/uuid@c7ee405)) > > ### Bug Fixes > > * improve v4() performance ([#894](https://github.com/uuidjs/uuid/issues/894)) ([5fd974c](uuidjs/uuid@5fd974c)) > * restore node: prefix ([#889](https://github.com/uuidjs/uuid/issues/889)) ([e1f42a3](uuidjs/uuid@e1f42a3)) > > [11.1.0](uuidjs/uuid@v11.0.5...v11.1.0) (2025-02-19) > ------------------------------------------------------------------------------- ... (truncated) Commits * [`7c1ea08`](uuidjs/uuid@7c1ea08) chore(main): release 14.0.0 ([#926](https://github.com/uuidjs/uuid/issues/926)) * [`3d2c5b0`](uuidjs/uuid@3d2c5b0) Merge commit from fork * [`f2c235f`](uuidjs/uuid@f2c235f) fix!: expect `crypto` to be global everywhere (requires node@20+) ([#935](https://github.com/uuidjs/uuid/issues/935)) * [`529ef08`](uuidjs/uuid@529ef08) chore: upgrade TypeScript and fixup types ([#927](https://github.com/uuidjs/uuid/issues/927)) * [`086fd79`](uuidjs/uuid@086fd79) chore: update dependencies ([#933](https://github.com/uuidjs/uuid/issues/933)) * [`dc4ddb8`](uuidjs/uuid@dc4ddb8) feat!: drop node@18 support ([#934](https://github.com/uuidjs/uuid/issues/934)) * [`0f1f9c9`](uuidjs/uuid@0f1f9c9) chore: switch to Biome for parsing and linting ([#932](https://github.com/uuidjs/uuid/issues/932)) * [`e2879e6`](uuidjs/uuid@e2879e6) chore: use maintained version of npm-run-all ([#930](https://github.com/uuidjs/uuid/issues/930)) * [`ffa3138`](uuidjs/uuid@ffa3138) fix: Use GITHUB\_TOKEN for release-please and enable npm provenance ([#925](https://github.com/uuidjs/uuid/issues/925)) * [`0423d49`](uuidjs/uuid@0423d49) docs: remove obsolete v1 option notes ([#915](https://github.com/uuidjs/uuid/issues/915)) * Additional commits viewable in [compare view](uuidjs/uuid@v10.0.0...v14.0.0) Maintainer changes This version was pushed to npm by [GitHub Actions](https://www.npmjs.com/~GitHub%20Actions), a new releaser for uuid since your current version. Install script changes This version adds `prepare` script that runs during installation. Review the package contents before updating. Updates `testcontainers` from 11.14.0 to 12.0.0 Release notes *Sourced from [testcontainers's releases](https://github.com/testcontainers/testcontainers-node/releases).* > v12.0.0 > ------- > > 🚨 Breaking Changes > ------------------ > > 1. Node 20 is EOL. Minimum engine requirement is now `>= 22.22`, matching the constraints from our dependencies. > 2. Previously, when no wait strategy was configured, Testcontainers defaulted to `Wait.forListeningPorts()`. > > The new default wait strategy uses a Docker healthcheck when one is configured on the container image or service, falling back to `Wait.forListeningPorts()` when no healthcheck is available. > > To keep the previous behaviour, configure `Wait.forListeningPorts()` explicitly: > > ``` > import { DockerComposeEnvironment, GenericContainer, Wait } from "testcontainers"; > > // Container: opt back into the previous default of waiting for listening ports > > const container = await new GenericContainer("my-image:latest") > > .withExposedPorts(8080) > > .withWaitStrategy(Wait.forListeningPorts()) > > .start(); > > > > // Compose: apply the previous default to all services > > const environment = await new DockerComposeEnvironment(composeFilePath, "docker-compose.yml") > > .withDefaultWaitStrategy(Wait.forListeningPorts()) > > .up(); > > > > // Compose: or apply it to a specific compose container > > const environment = await new DockerComposeEnvironment(composeFilePath, "docker-compose.yml") > > .withWaitStrategy("api-1", Wait.forListeningPorts()) > > .up(); > ``` > > --- > > Changes > ------- > > 🚀 Features > ---------- > > * Use configured health checks as the default wait strategy [`@digital88`](https://github.com/digital88) ([#1096](https://github.com/testcontainers/testcontainers-node/issues/1096)) > > 🐛 Bug Fixes > ----------- > > * Read `RYUK_CONTAINER_IMAGE` lazily so dotenv / other runtime overrides work [`@dvirarad`](https://github.com/dvirarad) ([#1323](https://github.com/testcontainers/testcontainers-node/issues/1323)) > * Use `/tmp` for Kafka startup script [`@cristianrgreco`](https://github.com/cristianrgreco) ([#1302](https://github.com/testcontainers/testcontainers-node/issues/1302)) > > 📖 Documentation > --------------- > > * Clarify PR defaults in AGENTS.md [`@cristianrgreco`](https://github.com/cristianrgreco) ([#1303](https://github.com/testcontainers/testcontainers-node/issues/1303)) > > 🧹 Maintenance > ------------- > > * Repair npm publish version updates [`@cristianrgreco`](https://github.com/cristianrgreco) ([#1330](https://github.com/testcontainers/testcontainers-node/issues/1330)) ... (truncated) Commits * [`80d537a`](testcontainers/testcontainers-node@80d537a) Fix npm publish version updates ([#1330](https://github.com/testcontainers/testcontainers-node/issues/1330)) * [`5e9bfff`](testcontainers/testcontainers-node@5e9bfff) Use configured health checks as the default wait strategy ([#1096](https://github.com/testcontainers/testcontainers-node/issues/1096)) * [`7f40327`](testcontainers/testcontainers-node@7f40327) Bump ghcr.io/devcontainers/features/node in the dependencies group ([#1318](https://github.com/testcontainers/testcontainers-node/issues/1318)) * [`df148bb`](testcontainers/testcontainers-node@df148bb) Bump the dependencies group across 18 directories with 20 updates ([#1321](https://github.com/testcontainers/testcontainers-node/issues/1321)) * [`1b7d67f`](testcontainers/testcontainers-node@1b7d67f) Bump the dependencies group across 1 directory with 30 updates ([#1322](https://github.com/testcontainers/testcontainers-node/issues/1322)) * [`b25bbea`](testcontainers/testcontainers-node@b25bbea) Read `RYUK_CONTAINER_IMAGE` lazily so dotenv / other runtime overrides work (... * [`cec8a5f`](testcontainers/testcontainers-node@cec8a5f) Bump the dependencies group across 1 directory with 23 updates ([#1300](https://github.com/testcontainers/testcontainers-node/issues/1300)) * [`78975ef`](testcontainers/testcontainers-node@78975ef) Bump the dependencies group across 16 directories with 18 updates ([#1299](https://github.com/testcontainers/testcontainers-node/issues/1299)) * [`303430f`](testcontainers/testcontainers-node@303430f) Use /tmp for Kafka startup script ([#1302](https://github.com/testcontainers/testcontainers-node/issues/1302)) * [`38fb397`](testcontainers/testcontainers-node@38fb397) Clarify PR defaults in AGENTS.md ([#1303](https://github.com/testcontainers/testcontainers-node/issues/1303)) * Additional commits viewable in [compare view](testcontainers/testcontainers-node@v11.14.0...v12.0.0)

Implicitly create buckets for CREATE TYPE

76bfb95

lvca self-requested a review March 9, 2023 14:39

lvca assigned gramian Mar 9, 2023

lvca added enhancement New feature or request bug and removed bug labels Mar 9, 2023

lvca added this to the 23.3.1 milestone Mar 9, 2023

lvca merged commit bd0fa87 into ArcadeData:main Mar 9, 2023

lvca added a commit that referenced this pull request Mar 9, 2023

chore: small refactoring to reuse the same method

ce28509

Refers to #926 (comment)

gramian mentioned this pull request Mar 13, 2023

SQL: CREATE TYPE does not automatically create BUCKETs #892

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Implicitly create buckets for CREATE TYPE#926

Implicitly create buckets for CREATE TYPE#926
lvca merged 1 commit into
ArcadeData:mainfrom
gramian:main

gramian commented Mar 9, 2023

Uh oh!

lvca commented Mar 9, 2023

Uh oh!

gramian commented Mar 9, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

gramian commented Mar 9, 2023

What does this PR do?

Motivation

Related issues

Additional Notes

Checklist

Uh oh!

lvca commented Mar 9, 2023

Uh oh!

gramian commented Mar 9, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants