Skip to content

#3946 remove old engine from query language list #3947

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
robfrank merged 1 commit into from
Apr 21, 2026
Merged

#3946 remove old engine from query language list #3947

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion studio/src/main/resources/static/query.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,6 @@
<option value="sqlScript">SQL Script</option>
<option value="opencypher">Open Cypher (New Native Engine)</option>
<option value="gremlin">Gremlin</option>
<option value="cypher">Cypher (Old Engine)</option>

@gemini-code-assist gemini-code-assist Bot Apr 21, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Removing the 'Cypher (Old Engine)' option is correct as per the PR description, but the cleanup appears incomplete. The getEditorMode() function (line 522) still contains logic for the "cypher" language, which is now unreachable from the UI and becomes dead code. Furthermore, this removal may affect the user experience for queries loaded from history: if a saved query has the "cypher" language, the select element will fail to match the value, causing the editor to default to SQL highlighting. Consider mapping "cypher" to "opencypher" in the history loading logic or removing the dead code in the JavaScript.

<option value="graphql">GraphQL</option>
<option value="mongo">MongoDB</option>
<option value="redis">Redis</option>
Expand Down
Loading