Skip to content

fix: resolve failing integration tests #3773

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
robfrank merged 6 commits into from
Apr 3, 2026
Merged

fix: resolve failing integration tests #3773

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
1b9fab4
fix: resolve two failing integration tests
robfrank Apr 2, 2026
e0fa751
fix: skip testCompareNaN in TinkerPop ProcessStandardSuite
robfrank Apr 3, 2026
ac2cc41
fix: RID.getPageId() fails when multiple databases active on same thread
robfrank Apr 3, 2026
7d4378d
fix: VertexIterator uses requireDatabase() via RID.asVertex() when mu…
robfrank Apr 3, 2026
976b63e
fix: RemoteMutableEdge.getOutVertex/getInVertex fail with NPE on null…
robfrank Apr 3, 2026
9619b0d
fix: use database.lookupByRID() instead of rid.asVertex() in remote test
robfrank Apr 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion engine/src/main/java/com/arcadedb/index/fulltext/LSMTreeFullTextIndex.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -701,8 +701,9 @@ public IndexCursor searchMoreLikeThis(final Set<RID> sourceRids, final MoreLikeT
final List<String> propertyNames = getPropertyNames();

if (propertyNames != null && !propertyNames.isEmpty()) {
final DatabaseInternal db = underlyingIndex.getComponent().getDatabase();

@gemini-code-assist gemini-code-assist Bot Apr 2, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

While the current implementation is correct, you can simplify the retrieval of the database instance by using the getComponent() method already available in this class, which delegates to the underlying index.

Suggested change
final DatabaseInternal db = underlyingIndex.getComponent().getDatabase();
final DatabaseInternal db = getComponent().getDatabase();

for (final RID sourceRid : sourceRids) {
final Identifiable identifiable = sourceRid.getRecord();
final Identifiable identifiable = db.lookupByRID(sourceRid, true);
if (identifiable == null)
continue;

Expand Down
Binary file added integration/src/test/resources/orientdb-export-customfields.gz
View file
Open in desktop
Binary file not shown.
Loading